Closed
Bug 589979
Opened 14 years ago
Closed 14 years ago
Generate username from email address
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
VERIFIED
FIXED
People
(Reporter: philikon, Assigned: philikon)
References
Details
(Whiteboard: [strings])
Attachments
(3 files, 2 obsolete files)
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
Instead of having to enter both username and email address on sign-up, users should only be required to provide the email address. Sync could auto-generate the username e.g. by hashing the email address.
To support existing users, the email address field in the setup wizard will also have to accept existing usernames (based on whether the value contains an @ character).
There's one follow-up for the server: We'll have to support changing the email address which means changing the username.
Assignee | ||
Comment 1•14 years ago
|
||
If we use SHA1 and express it in base32, the end up with 32 char long usernames, incidentally the max allowed length.
Assignee | ||
Comment 2•14 years ago
|
||
(In reply to comment #0)
> There's one follow-up for the server: We'll have to support changing the email
> address which means changing the username.
Filed bug 592933.
Depends on: 592933
Whiteboard: [strings]
Assignee | ||
Comment 3•14 years ago
|
||
Implement Utils.encodeBases32 and Utils.sha1Base32 as per RFC 4648.
Attachment #473569 -
Flags: review?(mconnor)
Assignee | ||
Comment 4•14 years ago
|
||
The Weave.Service.account property now holds whatever the user entered for email address/username. If it only contains characters valid for usernames, it is assumed to be a username. Otherwise it's SHA1 hashed and base32 encoded.
The special tab mangling (to avoid broken Basic Auth headers) is now obsolete.
Attachment #473572 -
Flags: review?(mconnor)
Assignee | ||
Comment 5•14 years ago
|
||
Consolidate email and username in the UI.
Attachment #473574 -
Flags: review?(mconnor)
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → philipp
Assignee | ||
Comment 6•14 years ago
|
||
Removing bug 592933 as a hard dependency.
No longer depends on: 592933
Assignee | ||
Comment 7•14 years ago
|
||
Backwards compatibility fix: Fall back to Service.username if Service.account isn't set.
Attachment #473572 -
Attachment is obsolete: true
Attachment #473936 -
Flags: review?(mconnor)
Attachment #473572 -
Flags: review?(mconnor)
Assignee | ||
Comment 8•14 years ago
|
||
Also update error messages mentioning user name (now mention email address where appropriate).
Attachment #473574 -
Attachment is obsolete: true
Attachment #474209 -
Flags: review?(mconnor)
Attachment #473574 -
Flags: review?(mconnor)
Comment 9•14 years ago
|
||
Comment on attachment 473569 [details] [diff] [review]
Part 1 (v1): Utils.encodeBases32 and Utils.sha1Base32
>- sha1: function sha1(message) {
>+ bytesAsHex: function digest(bytes) {
function bytesAsHex(bytes)
>+ do_check_eq(Utils.encodeBase32("Bacon is a vegetable."),
the perfect test.
Attachment #473569 -
Flags: review?(mconnor) → review+
Comment 10•14 years ago
|
||
Comment on attachment 473936 [details] [diff] [review]
Part 2 (v2): Account name mangling logic in Weave.Service
>diff --git a/services/sync/modules/service.js b/services/sync/modules/service.js
>- checkUsername: function WeaveSvc_checkUsername(username) {
>+ // For backwards compatibility with the Firefox UI.
please be specific about what versions of the UI have this dependency, so that when we drop support for < 4.0 final, we can excise this.
Attachment #473936 -
Flags: review?(mconnor) → review+
Updated•14 years ago
|
Attachment #474209 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 11•14 years ago
|
||
Part 1: http://hg.mozilla.org/services/fx-sync/rev/eb4a384e1ea2
Part 2: http://hg.mozilla.org/services/fx-sync/rev/cfa3a19d7333
Part 3: http://hg.mozilla.org/services/fx-sync/rev/a5e775604a56
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: Firefox Sync: UI → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•