Closed
Bug 596457
Opened 14 years ago
Closed 14 years ago
JM: Turn off methodjit if SSE2 is not supported
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | beta7+ |
People
(Reporter: dmandelin, Assigned: dvander)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
(deleted),
patch
|
dmandelin
:
review+
|
Details | Diff | Splinter Review |
We think lack of SSE2 is the main cause of the topcrash in bug 595351.
The assembler should already have an SSE2 detector, so for now, we can just check for SSE2 before calling into the methodjit.
Reporter | ||
Updated•14 years ago
|
blocking2.0: --- → ?
Assignee | ||
Comment 1•14 years ago
|
||
Tested on a 633MHz Celeron to have fixed the problem.
Reporter | ||
Comment 2•14 years ago
|
||
Comment on attachment 475655 [details] [diff] [review]
fix
I didn't even know we had that updateJITEnabled thing. It is good.
Attachment #475655 -
Flags: review?(dmandelin) → review+
Assignee | ||
Comment 3•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/89283cd55a98
This should probably land on m-c early - can someone set a blocking flag?
Whiteboard: fixed-in-tracemonkey
Assignee | ||
Comment 5•14 years ago
|
||
Thanks, good catch, I accidentally inverted a test.
http://hg.mozilla.org/tracemonkey/rev/b9113b21b88c
Comment 6•14 years ago
|
||
sayrer, can you mark blocking?
Comment 7•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•14 years ago
|
blocking2.0: ? → beta7+
Comment 8•14 years ago
|
||
(In reply to comment #7)
> http://hg.mozilla.org/mozilla-central/rev/89283cd55a98
This does not including David's followup linked in comment 5.
BTW, I think if (!(a || b)) is always less clear (more cluttered, harder to read, requiring mental application of De Morgan's Theorem) than if (!a && !b). rs=me on a fix to do that.
/be
Comment 9•14 years ago
|
||
Sayrer got the followup:
http://hg.mozilla.org/mozilla-central/rev/b9113b21b88c
/be
You need to log in
before you can comment on or make changes to this bug.
Description
•