Closed
Bug 599368
Opened 14 years ago
Closed 14 years ago
In embeddable editor image disappears when focused for resizing
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: pietro.brenna, Assigned: dbaron)
References
()
Details
(Whiteboard: [tbtrunkneeds])
Attachments
(1 file)
(deleted),
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:2.0b7pre) Gecko/20100923 Firefox/4.0b7pre Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b7pre) Gecko/20100923 Firefox/4.0b7pre In embeddable editor, when focusing an image to resize it, it disappears until blurred, testcase of a similar bug: https://bugzilla.mozilla.org/attachment.cgi?id=438361 Reproducible: Always Steps to Reproduce: 1.open the testcase 2.focus the image Actual Results: image disappears Expected Results: normal resizing operation Don't know if this helps: about:buildconfig Source Built from http://hg.mozilla.org/mozilla-central/rev/eec9a82ad740 Build platform target i686-pc-mingw32 Build tools Compiler Version Compiler flags d;D:\mozilla-build\msys\mozilla-build\python25\python2.5.exe -O e;D:\mozilla-build\msys\builds\moz2_slave\mozilla-central-win32-nightly\build\build\cl.py cl 14.00.50727.762 -TC -nologo -W3 -Gy -Fdgenerated.pdb -DNDEBUG -DTRIMMED -Zi -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1 d;D:\mozilla-build\msys\mozilla-build\python25\python2.5.exe -O e;D:\mozilla-build\msys\builds\moz2_slave\mozilla-central-win32-nightly\build\build\cl.py cl 14.00.50727.762 -GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fdgenerated.pdb -wd4800 -DNDEBUG -DTRIMMED -Zi -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1 Configure arguments --enable-application=browser --enable-update-channel=nightly --enable-update-packaging --enable-jemalloc --enable-tests
Updated•14 years ago
|
blocking2.0: --- → ?
Updated•14 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 1•14 years ago
|
||
Regression range using nightlies: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8e0fce7d5b49&tochange=79d0beec27b5
Comment 3•14 years ago
|
||
The first bad revision is: changeset: 52294:0aa1272e932f user: L. David Baron <dbaron@dbaron.org> date: Thu Sep 09 08:21:47 2010 -0700 summary: Clip replaced elements (for now, images, canvases, videos, and windowless plugins) to the border radius. (Bug 485501) r=roc a2.0=blocking:beta6
blocking2.0: ? → final+
Comment 5•14 years ago
|
||
Tentatively assigning to dbaron the same way that I assigned bug 596889 to him. :-)
Assignee: nobody → dbaron
Updated•14 years ago
|
Whiteboard: [tbtrunkneeds]
Assignee | ||
Comment 6•14 years ago
|
||
I think the test may be more interesting than the patch. I confirmed that the second assertion in the test fails without the patch; both pass with the patch.
Attachment #478919 -
Flags: review?(tnikkel)
Assignee | ||
Updated•14 years ago
|
Whiteboard: [tbtrunkneeds] → [tbtrunkneeds][needs review]
Updated•14 years ago
|
Attachment #478919 -
Flags: review?(tnikkel) → review+
Comment 7•14 years ago
|
||
I think that the test actually passes even without this patch applied, since selecting the images will show the image resize handles, therefore the snapshots will be different no matter what's displaying inside the image.
Comment 8•14 years ago
|
||
The test also changes the src of the image while it is selected and checks that it is different.
Comment 9•14 years ago
|
||
Right! Sorry for the bogus nit. /me learns to read the test output messages in patches next time!
Assignee | ||
Updated•14 years ago
|
Whiteboard: [tbtrunkneeds][needs review] → [tbtrunkneeds][needs landing]
Assignee | ||
Comment 10•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/ae327f054f26 Please note that the fix is NOT in beta 7.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [tbtrunkneeds][needs landing] → [tbtrunkneeds]
Target Milestone: --- → mozilla2.0b8
Updated•14 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•