Closed
Bug 600032
Opened 14 years ago
Closed 14 years ago
TM: set right compartment for Jetpack
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: gwagner, Assigned: gal)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
gwagner
:
review+
|
Details | Diff | Splinter Review |
#8 0x428bc5f9 in JS_Assert (s=0x42a09804 "cx->compartment != cx->runtime->defaultCompartment", file=0x42a04618 "/home/wagnerg/code/ws1/js/src/jsapi.cpp", ln=1344) at /home/wagnerg/code/ws1/js/src/jsutil.cpp:83 #9 0x4274e5a9 in JS_InitStandardClasses (cx=0x43b75020, obj=0x44602048) at /home/wagnerg/code/ws1/js/src/jsapi.cpp:1344 #10 0x4145dd7f in mozilla::jetpack::JetpackChild::Init (this=0x43b371d8, aParentProcessHandle=3195, aIOLoop=0x43e001d8, aChannel=0x43b031c8) at /home/wagnerg/code/ws1/js/jetpack/JetpackChild.cpp:141 #11 0x4146020d in mozilla::jetpack::JetpackProcessChild::Init (this=0x43b371c0) at /home/wagnerg/code/ws1/js/jetpack/JetpackProcessChild.cpp:52 #12 0x40368ddc in XRE_InitChildProcess (aArgc=1, aArgv=0xbffe02e4, aProcess=GeckoProcessType_Jetpack) at /home/wagnerg/code/ws1/toolkit/xre/nsEmbedFunctions.cpp:500 #13 0x080491ee in main (argc=3, argv=0xbffe02e4) at /home/wagnerg/code/ws1/ipc/app/MozillaRuntimeMain.cpp:67
Reporter | ||
Comment 2•14 years ago
|
||
There is more stuff to do here. Like in JetpackChild::RecvEvalScript(const nsString& code)
Assignee | ||
Comment 3•14 years ago
|
||
Attachment #478901 -
Attachment is obsolete: true
Assignee | ||
Comment 4•14 years ago
|
||
new patch, this should take care of all of jetpack
Reporter | ||
Comment 5•14 years ago
|
||
fix compilation issues
Attachment #479199 -
Attachment is obsolete: true
Reporter | ||
Comment 6•14 years ago
|
||
We crash now. Try to get a stack TEST-PASS | /Users/idefix2/moz/ws1/obj-ff-dbg/_tests/xpcshell/js/jetpack/tests/unit/test_jetpack.js | test passed PROCESS-CRASH | /Users/idefix2/moz/ws1/obj-ff-dbg/_tests/xpcshell/js/jetpack/tests/unit/test_jetpack.js | application crashed (minidump found) Neither MINIDUMP_STACKWALK nor MINIDUMP_STACKWALK_CGI is set, can't process dump.
Reporter | ||
Comment 7•14 years ago
|
||
(In reply to comment #6) > We crash now. Try to get a stack > > TEST-PASS | > /Users/idefix2/moz/ws1/obj-ff-dbg/_tests/xpcshell/js/jetpack/tests/unit/test_jetpack.js > | test passed > PROCESS-CRASH | > /Users/idefix2/moz/ws1/obj-ff-dbg/_tests/xpcshell/js/jetpack/tests/unit/test_jetpack.js > | application crashed (minidump found) > Neither MINIDUMP_STACKWALK nor MINIDUMP_STACKWALK_CGI is set, can't process > dump. That was my mistake. It passes now locally on my machine.
Assignee | ||
Comment 8•14 years ago
|
||
Land the sucker.
Reporter | ||
Updated•14 years ago
|
Summary: TM: set right compartment in JetpackChild::Init → TM: set right compartment for Jetpack
Reporter | ||
Updated•14 years ago
|
Attachment #479244 -
Flags: review+
Reporter | ||
Comment 9•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/fc4d99907bfe
Whiteboard: fixed-in-tracemonkey
Comment 10•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/fc4d99907bfe
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•