Closed Bug 601196 Opened 14 years ago Closed 14 years ago

Console styling busted by personas

Categories

(DevTools :: General, defect, P1)

x86
macOS
defect

Tracking

(blocking2.0 betaN+)

VERIFIED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: johnath, Assigned: pcwalton)

References

Details

(Whiteboard: [softblocker])

Attachments

(1 file)

Attached image Console with white text (deleted) —
See attached screenshot - this persona's colour choices make the javascript console interactions invisible, since the text is white-on-white (selected in the screenshot just to make it visible). The white text on checkboxes also doesn't look good. The choice of persona should not ever render the console unusable.
blocking2.0: --- → betaN+
this is the second bug like this, see bug 573840 I am amazed that the personas CSS code is so global. The console CSS is very targeted, I would assume the personas CSS should also do the same.
Personas affect the entire browser window, so all main-window elements need to be aware of them. I think you probably need some :-moz-lwtheme-brighttext selectors in this case.
(In reply to comment #2) > Personas affect the entire browser window, so all main-window elements need to > be aware of them. I think you probably need some :-moz-lwtheme-brighttext > selectors in this case. Ah, so in that case, can we use lightweight themes to create themes for the console?
(In reply to comment #3) > (In reply to comment #2) > > Personas affect the entire browser window, so all main-window elements need to > > be aware of them. I think you probably need some :-moz-lwtheme-brighttext > > selectors in this case. > > Ah, so in that case, can we use lightweight themes to create themes for the > console? I don't think you want that. You should just stop the text color inheritance together with the text shadow.
Assignee: nobody → pwalton
Blocks: devtools4b8
This seems to be fixed in the patches for bug 601667.
Status: NEW → ASSIGNED
Depends on: 601667
mass change: filter on PRIORITYSETTING
Priority: -- → P1
mass change: filter on PRIORITYSETTING
Blocks: devtools4
mass change: filter mail on BLOCKERSETTING
Severity: normal → blocker
We should confirm if this is fixed now that bug 601667 has landed.
Severity: blocker → normal
it is not :(
This seems to be fixed in the patches to bug 605621.
Whiteboard: [softblocker]
white text from personas no longer obscures the text in the console, so I'm marking this fixed. Courtesy of bug 605621.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Verified on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b10) Gecko/20100101 Firefox/4.0b10 ID:20110121161344
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: