Oops. So make upload works, just uploads to tinderbox-builds. I: a) looked at make upload's property change to find the directory on stage b) moved that directory to candidates/4.0b1-candidates/build1/PLATFORM for win32-i686, macosx-i686, linux-i686 I should fix.

adds build number + version to the release desktop builders

I hadn't replaced the addUploadSteps() in ReleaseMobileDesktopBuildFactory with the appropriate addMakeUploadSteps(). This patch should fix that; needs staging.

Comment on attachment 480727 [details] [diff] [review] release desktop build upload fix (custom) This looks good. As per our conversation, the worst case scenario is that the bits have to be manually shuffled on stage. This looks good to me, r+

Comment on attachment 480726 [details] [diff] [review] release desktop build upload fix (configs) http://hg.mozilla.org/build/buildbot-configs/rev/f5b5f5ff7423

Comment on attachment 480727 [details] [diff] [review] release desktop build upload fix (custom) http://hg.mozilla.org/build/buildbotcustom/rev/2bb90ca4849b

Close, but no cigar: symbolsUrl: 'http://stage.mozilla.org/pub/mozilla.org/mobile/nightly/4.0b1-candidates/build2/fennec-4.0b1.en-US.linux-i686.crashreporter-symbols.zip' packageUrl: 'http://stage.mozilla.org/pub/mozilla.org/mobile/nightly/4.0b1-candidates/build2/fennec-4.0b1.en-US.linux-i686.tar.bz2' testsUrl: 'http://stage.mozilla.org/pub/mozilla.org/mobile/nightly/4.0b1-candidates/build2/fennec-4.0b1.en-US.linux-i686.tests.zip' These need to s,nightly,candidates, and insert a PLATFORM after build2/.

symbolsUrl: 'http://stage.mozilla.org/pub/mozilla.org/mobile/nightly/4.0b1-candidates/build2/unsigned/fennec-4.0b1.en-US.win32.crashreporter-symbols.zip' packageUrl: 'http://stage.mozilla.org/pub/mozilla.org/mobile/nightly/4.0b1-candidates/build2/unsigned/fennec-4.0b1.en-US.win32.zip' testsUrl: 'http://stage.mozilla.org/pub/mozilla.org/mobile/nightly/4.0b1-candidates/build2/unsigned/fennec-4.0b1.en-US.win32.tests.zip' I'm going to guess this is hardcoded behavior in post_upload.py.

symbolsUrl: 'http://stage.mozilla.org/pub/mozilla.org/mobile/nightly/4.0b1-candidates/build2/fennec-4.0b1.en-US.mac.crashreporter-symbols.zip' packageUrl: 'http://stage.mozilla.org/pub/mozilla.org/mobile/nightly/4.0b1-candidates/build2/fennec-4.0b1.en-US.mac.dmg' testsUrl: 'http://stage.mozilla.org/pub/mozilla.org/mobile/nightly/4.0b1-candidates/build2/fennec-4.0b1.en-US.mac.tests.zip' maybe a --release-to-mobile-candidates-dir ?

going to nightly is the same behaviour as desktop. It looks like the missing thing is the platform ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/3.6.11-candidates/build2/mac/en-US/Firefox%203.6.11.dmg

I'm aware. Going to nightly is the wrong thing, however, because we use mobile/candidates/. I think we added a --nightly-dir option.

Also, windows shouldn't be going to unsigned/.

Looks like desktop's make package already puts its files in linux-i686/ type subdirectories, meaning that there's no need to specify a platform in post_upload.py. Adding for mobile, since there is no logic to create subdirectories for make upload there.

If the above post_upload.py changes go in, this is how we'd call it. I think if I test this, I want to get the Android release make package/make upload changes in as well.

Patches for this are in bug 603266.

Checked in, in bug 603266.