Closed Bug 603153 Opened 14 years ago Closed 13 years ago

Debug Windows .mozconfig with '--enable-trace-malloc' uselessly have overridden '--enable-jemalloc'

Categories

(Release Engineering :: General, defect, P5)

x86
Windows Server 2003
defect

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: sgautherie, Unassigned)

References

Details

Examples: http://mxr.mozilla.org/build/source/buildbot-configs/mozilla2/win32/mozilla-central/debug/mozconfig http://mxr.mozilla.org/build/source/buildbot-configs/seamonkey/win32/comm-central-trunk/debug/mozconfig { ac_add_options --enable-jemalloc ... ac_add_options --enable-trace-malloc } http://mxr.mozilla.org/build/source/buildbot-configs/thunderbird/win32/comm-central/debug/mozconfig { # Jemalloc gets disabled if trace-malloc is on, so don't bother enabling it here #ac_add_options --enable-jemalloc ac_add_options --enable-trace-malloc } Indeed: http://mxr.mozilla.org/mozilla-central/source/configure.in { 7227 if test "$NS_TRACE_MALLOC"; then 7228 MOZ_MEMORY= 7229 fi } This is not breaking anything, but it is rather useless and misleading! *** In addition, we should had an AC_MSG_WARN() in this case, to let the user know.
Blocks: 586962
Priority: -- → P5
Component: Release Engineering → Release Engineering: Automation (General)
QA Contact: release → catlee
Whiteboard: [configs][cleanup]
The mozconfigs are in the source tree now and someone already fixed it: cd mozilla-central/ grep jemalloc {b2g,browser}/config/mozconfigs/*/debug grep jemalloc mobile/*/config/mozconfigs/*/debug
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
Whiteboard: [configs][cleanup]
(In reply to Nick Thomas [:nthomas] from comment #1) > The mozconfigs are in the source tree now Then shouldn't the moved /buildbot-configs/ files be removed too?
Depends on: 728930, 558180
Product: mozilla.org → Release Engineering
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.