Closed
Bug 604337
Opened 14 years ago
Closed 14 years ago
Build/tool's l10n.py assumes a Firefox specific location for shipped-locales
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: bhearsum)
References
Details
(Whiteboard: [l10n])
Attachments
(2 files)
|
(deleted),
patch
|
rail
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
rail
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
Bug 399095 recently added some changes but hard-coded the location for shipped-locales:
http://hg.mozilla.org/build/tools/file/911c93dcc345/lib/python/release/l10n.py#l9
file = '%s/raw-file/%s/browser/locales/shipped-locales' % \
(sourceRepo, tag)
This, of course, breaks non-Firefox builds.
|
Reporter | |
Comment 1•14 years ago
|
||
(In reply to comment #0)
> file = '%s/raw-file/%s/browser/locales/shipped-locales' % \
> (sourceRepo, tag)
(and to be clear, Thunderbird uses /mail/ and SeaMonkey uses /suite/).
|
Assignee | |
Comment 2•14 years ago
|
||
D'oh, we need to be passing in appName here.
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → bhearsum
|
|
Assignee | |
Comment 3•14 years ago
|
||
Looks like you guys accidentally changed the hardcoding in http://hg.mozilla.org/build/tools/rev/5b9cd99b3f78, I've backed that out. I'll provide a real fix shortly.
|
|
Reporter | |
Comment 4•14 years ago
|
||
(In reply to comment #3)
> Looks like you guys accidentally changed the hardcoding in
> http://hg.mozilla.org/build/tools/rev/5b9cd99b3f78, I've backed that out. I'll
> provide a real fix shortly.
Oops, thanks - that was my local fix being pushed by mistake.
|
||
Updated•14 years ago
|
Whiteboard: [l10n]
|
|
Assignee | |
Comment 5•14 years ago
|
||
Attachment #483143 -
Flags: review?(rail)
|
|
Assignee | |
Comment 6•14 years ago
|
||
Attachment #483144 -
Flags: review?(rail)
|
||
Updated•14 years ago
|
Attachment #483143 -
Flags: review?(rail) → review+
|
|
||
Updated•14 years ago
|
Attachment #483144 -
Flags: review?(rail) → review+
|
|
Assignee | |
Comment 7•14 years ago
|
||
This tested fine in staging. Going to wait until 553300 lands to land this.
Depends on: 553300
|
|
Assignee | |
Comment 8•14 years ago
|
||
Comment on attachment 483143 [details] [diff] [review]
pass in appName to script
changeset: 938:cb41c45ae30f
Attachment #483143 -
Flags: checked-in+
|
|
Assignee | |
Comment 9•14 years ago
|
||
Comment on attachment 483144 [details] [diff] [review]
pass appName to script in factory
Landed this on 0.8.0 and default:
0.8.0: changeset: 1090:b0da779cfbca
default: changeset: 1091:c72c38aaff61
Attachment #483144 -
Flags: checked-in+
|
|
Assignee | |
Comment 10•14 years ago
|
||
Should be fixed now.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•