Closed
Bug 604431
Opened 14 years ago
Closed 14 years ago
Command Completion broken on today's build in JSTerm
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(blocking2.0 beta7+)
RESOLVED
FIXED
Firefox 4.0b7
Tracking | Status | |
---|---|---|
blocking2.0 | --- | beta7+ |
People
(Reporter: rcampbell, Assigned: ddahl)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
Web Console's JSTerm is no longer completing entries.
today's build: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre)
Gecko/20101014 Firefox/4.0b8pre
built from:
http://hg.mozilla.org/mozilla-central/rev/ad0a0be8be74
Assignee | ||
Comment 2•14 years ago
|
||
I'm seeing this:
Error: uncaught exception: [Exception... "Component is not available" nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)" location: "JS frame :: resource:///modules/HUDService.jsm :: JSPropertyProvider :: line 3878" data: no]
Error: obj.__lookupGetter__ is not a function
Source File: resource:///modules/HUDService.jsm
Line: 3861
Updated•14 years ago
|
Blocks: devtools4b8
Assignee | ||
Comment 3•14 years ago
|
||
We did not know this happend via our tests due to this changeset:
http://hg.mozilla.org/mozilla-central/rev/29c228a4d7eb
Reporter | ||
Comment 4•14 years ago
|
||
was there a bug added to re-enable them anywhere? Johnny, help us out here.
Updated•14 years ago
|
blocking2.0: ? → beta7+
Comment 5•14 years ago
|
||
ddahl has a fix to this which he has said is a "one-liner". The fix is apparently visible in another patch:
https://bugzilla.mozilla.org/show_bug.cgi?id=587734#c60
but ddahl will break that out to land it for beta 7.
Assignee: nobody → ddahl
Updated•14 years ago
|
Assignee | ||
Comment 6•14 years ago
|
||
I am attaching a patch momentarily
Assignee | ||
Comment 7•14 years ago
|
||
one liner that fixes tab completion
Attachment #484027 -
Flags: review?(sdwilsh)
Reporter | ||
Comment 8•14 years ago
|
||
this fix clears the errors from the disabled tests in bug 604536. Feedback+++++ from me.
Updated•14 years ago
|
Attachment #484027 -
Flags: review?(sdwilsh) → review+
Assignee | ||
Comment 9•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 10•14 years ago
|
||
landed on BRANCH:
http://hg.mozilla.org/mozilla-central/rev/82255b586ada
Updated•14 years ago
|
Target Milestone: --- → Firefox 4.0b7
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•