Closed
Bug 604536
Opened 14 years ago
Closed 14 years ago
Re-enable tests disabled by Compartments landing
Categories
(DevTools :: General, defect)
Tracking
(blocking2.0 beta7+)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | beta7+ |
People
(Reporter: ddahl, Assigned: rcampbell)
References
Details
This changeset shows 3 tests tat were disabled by the compartments landing. We should track here what needs to happen to re-enable them. bug 604431 details the symptoms of one of these issues, the tab-completion.
See http://hg.mozilla.org/mozilla-central/rev/29c228a4d7eb
Assignee | ||
Comment 2•14 years ago
|
||
Updated•14 years ago
|
Blocks: devtools4b7
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•14 years ago
|
||
sounds like the fix in bug 604431 will fix one of these tests.
Depends on: 604431
Assignee | ||
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 5•14 years ago
|
||
(In reply to comment #4)
> http://hg.mozilla.org/mozilla-central/rev/84d82ff7a9d8
I don't think this needs to land on the branch, as robcee tells me that the tests weren't disabled there. Though they might be when we merge GC compartments over? So confused!
Assignee | ||
Comment 6•14 years ago
|
||
yeah, this is confusing.
We had a number of tests broken up post-b7 branch detailed in bug 581069. These weren't ported back.
The patch to reapply the disabled tests here doesn't apply cleanly to b7 as a result.
BUT! These individual tests were never disabled on b7, so they will still run (and indeed do run, just verified) just fine there.
We could back-port the split tests, though some of them may rely on non-branchy code. In which case, they'd have to be disabled. If you and the other release drivers think this is warranted, we can do it, but I wanted to make sure we knew where we stood with this bug.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•