Closed
Bug 605351
Opened 14 years ago
Closed 14 years ago
fix and re-enable browser_webconsole_bug_593003_iframe_wrong_hud.js
Categories
(DevTools :: General, defect, P3)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rcampbell, Assigned: msucan)
References
Details
(Whiteboard: [patchclean:1021] [console-1])
Attachments
(1 file)
|
(deleted),
patch
|
ddahl
:
feedback-
|
Details | Diff | Splinter Review |
This test was disabled around the same time as the compartments landing, but I think was shut off separately from the original tests. We should get it fixed up and operational again.
Followup from bug 604536.
|
||
Updated•14 years ago
|
Blocks: devtools4b8
|
Assignee | |
Comment 1•14 years ago
|
||
Proposed test fix. All tests pass in debug and opt builds (Linux).
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [patchclean:1021]
|
||
Comment 2•14 years ago
|
||
Comment on attachment 485001 [details] [diff] [review]
proposed test fix
Is this patch missing the actual test bits where we verify things? It looks like it just opens tabs and closes them.
Attachment #485001 -
Flags: feedback?(ddahl) → feedback-
|
|
Assignee | |
Comment 3•14 years ago
|
||
(In reply to comment #2)
> Comment on attachment 485001 [details] [diff] [review]
> proposed test fix
>
> Is this patch missing the actual test bits where we verify things? It looks
> like it just opens tabs and closes them.
This patch fixes the test. Indeed, in the patch the actual tests are not visible, however please apply the patch and see the resulting mochitest file. It opens two tabs and it tests if the iframe network request is recorded in the correct tab.
|
|
||
Updated•14 years ago
|
Whiteboard: [patchclean:1021] → [patchclean:1021] [console-1]
|
|
Assignee | |
Comment 5•14 years ago
|
||
This bug is already fixed, but I don't know by what other bug.
|
|
||
Comment 6•14 years ago
|
||
It's unfortunate that we don't know when this was fixed, but there's no point leaving this bug open if we know that it is fixed.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•