User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101024 Firefox/4.0b8pre Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101024 Firefox/4.0b8pre While all other links open in new tabs when clicked in an app tab, including history and bookmarks, pressing the "Home" button will open the home page within the app tab. This should be fixed by making it open in a new tab if clicked while in an app tab. Reproducible: Always

What should happen if you're in an app tab with the same domain as your home page?

(In reply to comment #1) > What should happen if you're in an app tab with the same domain as your home > page? Why should that make a difference?

(In reply to comment #2) > (In reply to comment #1) > > What should happen if you're in an app tab with the same domain as your home > > page? > > Why should that make a difference? Suppose your home page is your gmail inbox. If you are reading a message in your gmail app tab, should the home button make a new tab for you, or bring you back to your inbox in the app tab? I feel like I would expect it to bring me back to my inbox in the app tab, but I'm not sure if that's the behavior we want.

Just because something is an app does not mean that two or more tabs with it would not be useful. I may want to reference one email with composing another, or copy sections of a document to another, or review a one calendar will making changes to another. It would annoy me greatly if Firefox tried at anytime to prevent me from reopening an app just because it is open elsewhere.

I think it would seem confusing to most users; but that's just my opinion. Also, for example, Gmail and Google are the same domain, which could cause problems.

It would only cause problems if you *did* try to prevent normal tabs from

Sorry, got cut off. :( It would only cause problems if you *did* try to prevent normal tabs from hosting a site also open in an app tab somewhere else

bookmarks are always opened in a new tab even if they have the same domain

Yea, I would say we open a new tab when the home button is clicked, but only if the focused app tab doesn't match the home page url. If there are multiple home pages, always open all of them in new tabs (that way they are together at the end of the tab strip). Historically the home tab button has not opened a new tab (except in the case of multiple home pages, and even then it would overwrite the current tab first). App tabs make everything a little bit more complicated but since they aren't (completely) replacing the functionality of home page(s), we should make the effort to protect them for the user.

(covering Limi's bugmail until he gets back) >App tabs make everything a little bit more complicated but since they >aren't (completely) replacing the functionality of home page(s), we should make >the effort to protect them for the user. I agree that in the short term we need to protect app tabs from being navigated to other domains, so the home button needs to launch a new tab. In the long term, this won't be an issue since we'll be introducing the Home Tab, and app tabs are going to be chromeless by default.

This patch always opens your home page in a new tab if the current tab is an app tab. I initially wrote a patch that checks whether the current app tab url matches the home page url, but I think it's more consistent for us to always open a new tab. Also, it can get messy if you try to take redirects into account (like if you're on http://www.google.com/ but your homepage is http://google.com/).

Comment on attachment 487476 [details] [diff] [review] patch nit: checking where == "current" before gBrowser.selectedTab.pinned is slightly more efficient in theory :-)

This works if you use the mouse to click the home button or Home on the History menu. However it doesn't work if you use either keyboard shortcuts Alt+S H or Alt+Home. In these later 2 cases the home page overwrites the contents of the app tab. Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101106 Firefox/4.0b8pre

Apologies for the double post, it is actually only Alt+Home that overwrites the contents of an app tab.

(In reply to comment #15) > menu. However it doesn't work if you use either keyboard shortcuts Alt+S H or > Alt+Home. In these later 2 cases the home page overwrites the contents of the > app tab. I cannot see this with Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101106 Firefox/4.0b8pre. All the cases work fine for me.

(In reply to comment #16) > Apologies for the double post, it is actually only Alt+Home that overwrites the > contents of an app tab. Please scratch my last comment. You are right. Lets reopen the bug for the remaining fix.

Alt+Home calls BrowserHome instead of BrowserGoHome.

Please file a new bug.

Filed bug 610196.

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101107 Firefox/4.0b8pre ID:20101107030911