Closed
Bug 609160
Opened 14 years ago
Closed 14 years ago
Wizard header labels should wrap
Categories
(Toolkit :: XUL Widgets, defect)
Toolkit
XUL Widgets
Tracking
()
VERIFIED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: philikon, Assigned: philikon)
References
Details
(Whiteboard: [hardblocker])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #608807 +++
Setup wizard title should wrap over two lines.
|
Assignee | |
Comment 1•14 years ago
|
||
Instead of porting the hack from bug 608807, we should just fix the wizard widgets to allow header labels to wrap (this blocks 627166). Morphing this bug into a Toolkit :: XUL Widgets bug.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Component: Firefox Sync: UI → XUL Widgets
Product: Mozilla Services → Toolkit
QA Contact: sync-ui → xul.widgets
Summary: Sync UI: Setup dialog too small in l10n builds → Wizard header labels should wrap
|
|
Assignee | |
Comment 2•14 years ago
|
||
Bug 627166 is a hardblocker, so this should be one too. Does that logic make sense? I think so.
blocking2.0: --- → ?
Whiteboard: [hardblocker?]
|
|
Assignee | |
Comment 3•14 years ago
|
||
This puts the text for the wizard labels into a text node rather than a <label>'s 'value' attribute. That way they can wrap.
Attachment #510781 -
Flags: review?(enndeakin)
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [hardblocker?] → [hardblocker?][has patch][needs review enn]
|
||
Comment 4•14 years ago
|
||
(In reply to comment #3)
> Created attachment 510781 [details] [diff] [review]
> v1
>
> This puts the text for the wizard labels into a text node rather than a
> <label>'s 'value' attribute. That way they can wrap.
xbl:inherits="xbl:text=label" will do that for you.
|
|
Assignee | |
Comment 5•14 years ago
|
||
(In reply to comment #4)
> xbl:inherits="xbl:text=label" will do that for you.
Oooh, didn't know about that one. Cool, thanks! Will round up a new patch.
|
|
Assignee | |
Comment 6•14 years ago
|
||
Does the same thing as v1, but with much less code (using inherit="xbl:text=label")
Attachment #510781 -
Attachment is obsolete: true
Attachment #511049 -
Flags: review?(enndeakin)
Attachment #510781 -
Flags: review?(enndeakin)
|
||
Updated•14 years ago
|
blocking2.0: ? → final+
Whiteboard: [hardblocker?][has patch][needs review enn] → [hardblocker][has patch][needs review enn]
|
||
Updated•14 years ago
|
Attachment #511049 -
Flags: review?(enndeakin) → review+
|
|
Assignee | |
Comment 7•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [hardblocker][has patch][needs review enn] → [hardblocker]
You need to log in
before you can comment on or make changes to this bug.
Description
•