Closed Bug 610984 Opened 14 years ago Closed 14 years ago

Refactor AtomWB to expose some core functionality to MMgc

Categories

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Q3 11 - Serrano

People

(Reporter: lhansen, Assigned: lhansen)

References

Details

(Whiteboard: has-patch)

Attachments

(1 file)

Attached patch Patch (deleted) — Splinter Review
The exact tracing work needs to be able to know a little bit about AtomWB, just like it knows a little bit about Atom. Since the AtomWB methods are closely tied to eg AvmCore::atomWriteBarrier{_ctor,_dtor,} it's a major pain to move AtomWB outright into MMgc. Instead, we can create a base class in MMgc that has the necessary functionality and from can be extended by AtomWB.
Attachment #489474 - Flags: review?(treilly)
Attachment #489474 - Flags: review?(treilly) → review+
Why not just move atomWriteBarrier* from AvmCore into MMgc? (And provide inline wrappers in AvmCore)
That was the other possibility that was discussed. The subclassing seemed like much the smaller change and was attractive for that reason.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Flags: flashplayer-bug-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: