Closed
Bug 613226
Opened 14 years ago
Closed 14 years ago
release mail notification sends mail for all active release branches anytime any builder finishes
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: salbiz)
References
Details
Attachments
(1 file)
(deleted),
patch
|
bhearsum
:
review+
bhearsum
:
feedback+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
I thought this was just on the ChangeNotifier at first but I'm now noticing that I get mail for 4.0b6, 3.6.13, and 3.5.14 whenever a builder for my 3.6.13 staging run finishes.
Assignee | ||
Comment 1•14 years ago
|
||
Probably an unforeseen consequence of landing the multi-branch stuff. The MailNotifier hangs onto all builders with category in ['release',]. This doesn't explain why ChangeNotifier is also sending out dup emails for tagging
Assignee: nobody → salbiz
Assignee | ||
Comment 2•14 years ago
|
||
I was able to stop duplicate emails from MailNotifier altogether by filtering by builder category, could you please confirm that the only dup emails you get are when steps _complete_? I could not reproduce any dup emails from the ChangeNotifiers (i.e. when tagging starts, or signing finishes)
Attachment #491660 -
Flags: feedback?(lsblakk)
Attachment #491660 -
Flags: feedback?(bhearsum)
Reporter | ||
Comment 3•14 years ago
|
||
Yeah, you're right...only when steps finish. I only get 3.6.13 mail from the ChangeNotifier. Sorry about the confusion!
Reporter | ||
Comment 4•14 years ago
|
||
Comment on attachment 491660 [details] [diff] [review]
filter release builder categories by branch
This seems fine, let's hold off on landing it until after 3.6.13/3.5.16 since it's not critical.
Attachment #491660 -
Flags: review+
Attachment #491660 -
Flags: feedback?(bhearsum)
Attachment #491660 -
Flags: feedback+
Reporter | ||
Comment 5•14 years ago
|
||
Lukas, do you have any input here?
Reporter | ||
Comment 6•14 years ago
|
||
Comment on attachment 491660 [details] [diff] [review]
filter release builder categories by branch
changeset: 1220:ad35199f9125
Attachment #491660 -
Flags: feedback?(lsblakk) → checked-in+
Reporter | ||
Comment 7•14 years ago
|
||
All done here.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•