Closed
Bug 617539
Opened 14 years ago
Closed 13 years ago
get rid of _MOZILLA_2_0_BRANCH interfaces on trunk after we branch
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
People
(Reporter: tnikkel, Assigned: benjamin)
References
Details
Attachments
(19 files, 2 obsolete files)
(deleted),
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
smontagu
:
review+
mounir
:
checkin+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
emorley
:
review+
mounir
:
feedback+
Ms2ger
:
checkin+
|
Details | Diff | Splinter Review |
We've had to add a number of _MOZILLA_2_0_BRANCH interfaces to avoid IID changes. We should get rid of them on trunk once we branch for real.
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → benjamin
Assignee | ||
Comment 5•14 years ago
|
||
Because of ill-conceived %{C++ blocks in nsIPluginHost, the vtables were ending up incorrect, so I had to do a slight bit more surgery for this one.
Attachment #518481 -
Flags: review?(jst)
![]() |
||
Comment 7•14 years ago
|
||
Comment on attachment 518479 [details] [diff] [review] nsIWidget, rev. 1 In nsIWidget.h you can remove the old transparency method UpdatePossiblyTransparentRegion as well. UpdateTransparentRegion replaces it.
Attachment #518479 -
Flags: review?(jmathies) → review+
![]() |
||
Comment 8•14 years ago
|
||
Comment on attachment 518480 [details] [diff] [review] nsIDOMWindowUtils, rev. 1 You need to rev the nsIDOMWindowUtils iid. r=me with that.
Attachment #518480 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 9•14 years ago
|
||
Assignee | ||
Updated•14 years ago
|
Attachment #519668 -
Flags: review?(jonas)
Assignee | ||
Updated•14 years ago
|
Attachment #519677 -
Flags: review? → review?(gavin.sharp)
Updated•14 years ago
|
Attachment #519677 -
Flags: review?(gavin.sharp) → review+
Updated•14 years ago
|
Attachment #519676 -
Flags: review?(Olli.Pettay) → review+
Updated•14 years ago
|
Attachment #519678 -
Flags: review?(Olli.Pettay) → review+
Comment on attachment 519668 [details] [diff] [review] nsIDOMNSDocument, rev. 1 Thanks!
Attachment #519668 -
Flags: review?(jonas) → review+
Comment on attachment 519668 [details] [diff] [review] nsIDOMNSDocument, rev. 1 Oh, but you do need to rev the nsIDocument iid
Comment 15•14 years ago
|
||
Comment on attachment 519677 [details] [diff] [review] nsIContentPrefService, rev. 1 Oh, this actually revs the IID on the wrong interface (nsIContentPrefObserver instead of nsIContentPrefService) - need to fix that!
Assignee | ||
Updated•14 years ago
|
Attachment #519766 -
Flags: review? → review?(enndeakin)
Updated•14 years ago
|
Attachment #519767 -
Flags: review?(dtownsend) → review+
Updated•14 years ago
|
Attachment #519762 -
Flags: review?(Olli.Pettay) → review+
Comment on attachment 519760 [details] [diff] [review] nsIContentViewer, rev. 1 r=me if you rev the iid.
Attachment #519760 -
Flags: review?(jonas) → review+
Updated•14 years ago
|
Attachment #519766 -
Flags: review?(enndeakin) → review+
![]() |
||
Comment 25•14 years ago
|
||
Comment on attachment 519759 [details] [diff] [review] nsIDocShell, rev. 1 r=me
Attachment #519759 -
Flags: review?(bzbarsky) → review+
![]() |
||
Comment 26•14 years ago
|
||
Comment on attachment 519765 [details] [diff] [review] nsIFrameLoader, rev. 1 Nix the interface from the idl file too? And rev the nsIFrameLoader iid. r=me with those two changes.
Attachment #519765 -
Flags: review?(bzbarsky) → review+
![]() |
||
Comment 27•14 years ago
|
||
Comment on attachment 519768 [details] [diff] [review] nsIRadioGroupContainer, rev. 1 r=me, but please coordinate with Mounir: he has a bunch of changes to this code too.
Attachment #519768 -
Flags: review?(bzbarsky) → review+
Updated•14 years ago
|
Attachment #519764 -
Flags: review?(jmuizelaar) → review+
Updated•14 years ago
|
Attachment #521573 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 29•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/66b1dae86e99 - nsIDOMWindowUtils http://hg.mozilla.org/mozilla-central/rev/4751ff283ab4 - nsIHTMLEditor http://hg.mozilla.org/mozilla-central/rev/ee51cd544882 - nsIDOMNSDocument http://hg.mozilla.org/mozilla-central/rev/9722ce9b7c3d - nsIFocusManager http://hg.mozilla.org/mozilla-central/rev/c2e52bd90993 - nsIContentPrefService http://hg.mozilla.org/mozilla-central/rev/82218ad4a475 - nsIDOMHistory http://hg.mozilla.org/mozilla-central/rev/4b3e51d80e8f - nsIContentViewer http://hg.mozilla.org/mozilla-central/rev/fde85fc5f878 - nsIDOMHTMLSelectElement http://hg.mozilla.org/mozilla-central/rev/ec57c96251e9 - nsIDOMWebGLRenderingContext http://hg.mozilla.org/mozilla-central/rev/8090e860a533 - nsIFrameLoader http://hg.mozilla.org/mozilla-central/rev/b9b31e5840b7 - nsIMenuBoxObject http://hg.mozilla.org/mozilla-central/rev/3e2d1dd1962e - nsIAppStartup http://hg.mozilla.org/mozilla-central/rev/e9ab3e8d4303 - nsIWidget Still remaining: nsIEditor, nsIRadioGroupContainer, nsIPresShell, nsIPlugin* (we might skip this because of delibxulification), and nsIScreen.
Attachment #522286 -
Flags: review?(tnikkel)
Reporter | ||
Updated•14 years ago
|
Attachment #522286 -
Flags: review?(tnikkel) → review+
![]() |
||
Updated•14 years ago
|
Whiteboard: not-ready-for-cedar
http://hg.mozilla.org/mozilla-central/rev/0dc8fb9d0bc3 - nsIPresShell
Comment 33•14 years ago
|
||
Comment on attachment 518481 [details] [diff] [review] nsIPlugin*, rev. 1 Duh, I reviewed this when the request was made, but clearly forgot to mark it :( r=jst
Attachment #518481 -
Flags: review?(jst) → review+
Comment on attachment 525083 [details] [diff] [review] nsIEditor Please land this before we branch :-)
Attachment #525083 -
Flags: review?(roc) → review+
Comment 37•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/3aebb305dee5 http://hg.mozilla.org/mozilla-central/rev/a7ba826ccbdf
Comment 38•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/0d60751c978e (nsIContentUtils_MOZILLA_2_0_BRANCH) This patch is a straight backout of http://hg.mozilla.org/mozilla-central/rev/5e1f1bb2bb87 which added that class for the mere sake of non-libxul builds (which are now history).
Comment 39•14 years ago
|
||
Josh, should I back http://hg.mozilla.org/mozilla-central/rev/3aebb305dee5 out? Benjamin said that he left this unlanded on purpose because you had a pending patch to remove these entirely...
Comment 40•14 years ago
|
||
Don't back it out, the removal patch of mine won't be in FF5 and I have to update it anyway. I'd prefer to have the MOZILLA_2_0_BRANCH stuff gone now. Thanks for landing it.
Comment 41•14 years ago
|
||
The patch for this bug contains a mistake that triggered bug 651177.
Blocks: 651117
Updated•14 years ago
|
Updated•14 years ago
|
Comment 42•14 years ago
|
||
According to MXR, there is now just the following remaining... - nsIRadioGroupContainer (dealt with by Attachment #519768 [details] [diff], pending comment 27) - nsIMarkupDocumentViewer - nsIScreen - A leftover from nsIDOMWindowUtils, presume it can be taken out too? http://mxr.mozilla.org/mozilla-central/source/layout/ipc/test-ipcbrowser-content.js#8 Presume it's ok for me to work on nsIMarkupDocumentViewer and nsIScreen / no one else is currently doing them?
Comment on attachment 535965 [details] [diff] [review] nsIScreen, rev. 1 Review of attachment 535965 [details] [diff] [review]: -----------------------------------------------------------------
Attachment #535965 -
Flags: review?(roc) → review+
Updated•14 years ago
|
Attachment #535962 -
Flags: review?(smontagu) → review+
Comment 46•14 years ago
|
||
Comment on attachment 535962 [details] [diff] [review] nsIMarkupDocumentViewer, rev. 1 http://hg.mozilla.org/projects/cedar/rev/102449094763
Attachment #535962 -
Flags: checked-in+
Comment 47•14 years ago
|
||
(In reply to comment #46) > Comment on attachment 535962 [details] [diff] [review] [review] > nsIMarkupDocumentViewer, rev. 1 > > http://hg.mozilla.org/projects/cedar/rev/102449094763 http://hg.mozilla.org/mozilla-central/rev/102449094763
Updated•13 years ago
|
Attachment #535962 -
Flags: checked-in+ → checkin+
Comment 48•13 years ago
|
||
Comment on attachment 535965 [details] [diff] [review] nsIScreen, rev. 1 Fails try; breaking out to bug 672166 to resolve.
Attachment #535965 -
Attachment is obsolete: true
Attachment #535965 -
Flags: review+
Comment 49•13 years ago
|
||
Other than the dependant bugs, nsIRadioGroupContainer is the last interface needing to be dealt with here (according to MXR at least), so have updated the existing patch so this can be closed. Is bsmedbergs patch updated to tip, carrying forwards bz's r+ Mounir, can you confirm this is ok to land please? (see comment 27)
Attachment #519768 -
Attachment is obsolete: true
Attachment #546514 -
Flags: review+
Attachment #546514 -
Flags: feedback?(mounir)
Comment 50•13 years ago
|
||
Comment on attachment 546514 [details] [diff] [review] nsIRadioGroupContainer, rev. 1.1 Review of attachment 546514 [details] [diff] [review]: ----------------------------------------------------------------- I indeed have some patches touching nsIRadioGroupContainer but given that they still haven't landed, I will take the burden of the merge instead of delay this more. Thanks for refreshing the patch Ed :)
Attachment #546514 -
Flags: feedback?(mounir) → feedback+
Comment 51•13 years ago
|
||
Comment on attachment 546514 [details] [diff] [review] nsIRadioGroupContainer, rev. 1.1 Great, thanks Mounir :-) Passed try: http://dev.philringnalda.com/tbpl/?tree=Try&rev=6ef91a400cf4
Attachment #546514 -
Flags: checkin?
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: not-ready-for-cedar
Comment 52•13 years ago
|
||
Comment on attachment 546514 [details] [diff] [review] nsIRadioGroupContainer, rev. 1.1 http://hg.mozilla.org/integration/mozilla-inbound/rev/1ed3d5d62d91
Attachment #546514 -
Flags: checkin? → checkin+
Updated•13 years ago
|
Keywords: checkin-needed
Comment 53•13 years ago
|
||
Comment on attachment 546514 [details] [diff] [review] nsIRadioGroupContainer, rev. 1.1 http://hg.mozilla.org/mozilla-central/rev/1ed3d5d62d91
Comment 54•13 years ago
|
||
Now that bug 672166 has landed, believe we're all done here (comment remnant being dealt with in that bug): http://mxr.mozilla.org/mozilla-central/search?string=MOZILLA_2&case=1
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•