Closed
Bug 664979
Opened 13 years ago
Closed 13 years ago
Merge nsISHistory_2_0_BRANCH into nsISHistory
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: emorley, Assigned: emorley)
References
Details
(Keywords: dev-doc-complete, Whiteboard: [inbound])
Attachments
(2 files, 1 obsolete file)
|
(deleted),
patch
|
emorley
:
review+
emorley
:
checkin+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
bzbarsky
:
review+
dholbert
:
checkin+
|
Details | Diff | Splinter Review |
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → bmo
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #540190 -
Flags: review?(bzbarsky)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 540190 [details] [diff] [review]
Merge nsISHistory_2_0_BRANCH
You don't need to change the history CID. r=me with that change taken out.
Attachment #540190 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Updated for review comments, carrying forwards r+.
For whomever checks this in, it has passed try (comment 1) and has author/commit message set already. Thanks! :-)
Attachment #540190 -
Attachment is obsolete: true
Attachment #540219 -
Flags: review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
|
||
Comment 5•13 years ago
|
||
Comment on attachment 540219 [details] [diff] [review]
Merge nsISHistory_2_0_BRANCH v1.1
> browser.webNavigation.sessionHistory.
>- QueryInterface(Ci.nsISHistory_2_0_BRANCH).reloadCurrentEntry();
>+ QueryInterface(Ci.nsISHistory).reloadCurrentEntry();
sessionHistory is already nsISHistory, no need to call QueryInterface again.
|
|
Assignee | |
Comment 6•13 years ago
|
||
Removes unnecessary QueryInterface(Ci.nsISHistory) call, per comment 5.
Thanks for spotting that Neil :-)
Attachment #540321 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #540219 -
Flags: checkin+
|
|
Assignee | |
Comment 7•13 years ago
|
||
|
|
||
Comment 8•13 years ago
|
||
Comment on attachment 540321 [details] [diff] [review]
Remove unnecessary QueryInterface call
r=me
Attachment #540321 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 9•13 years ago
|
||
Comment on attachment 540321 [details] [diff] [review]
Remove unnecessary QueryInterface call
Reopening so this shows on the checkin-needed searches.
Only the "Remove unnecessary QueryInterface call" patch is left to be landed - thanks! (Has passed try, see comment 7.
Attachment #540321 -
Flags: checkin?
|
|
Assignee | |
Updated•13 years ago
|
|
||
Comment 10•13 years ago
|
||
"Remove unnecessary QueryInterface call" patch landed:
http://hg.mozilla.org/integration/mozilla-inbound/rev/484adb0cf79b
Keywords: checkin-needed
Whiteboard: [inbound]
|
|
||
Updated•13 years ago
|
Attachment #540321 -
Flags: checkin? → checkin+
|
||
Comment 11•13 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
|
|
Assignee | |
Comment 12•13 years ago
|
||
I'm presuming this page needs updating:
https://developer.mozilla.org/en/NsISHistory
Keywords: dev-doc-needed
Keywords: dev-doc-needed → dev-doc-complete
|
|
Assignee | |
Comment 13•13 years ago
|
||
Thanks Trevor :-)
You need to log in
before you can comment on or make changes to this bug.
Description
•