Closed
Bug 619801
Opened 14 years ago
Closed 14 years ago
Disable Update checking for Fennec 4.0 beta builds and forward
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(fennec2.0b4+)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
fennec | 2.0b4+ | --- |
People
(Reporter: tchung, Assigned: mbrubeck)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
After chatting with mfinkle, it sounds like Android update in market is going to be the path to take. If thats the case, then its unnecessary to keep the "Check for updates" button present in any Fennec Beta builds. It should only exist on nightly builds.
Repro:
1) install Fennec 4 beta 3
2) open prefs > About Firefox and click Go To Page
3) when about:firefox page appears, click "Check for updates"
4) No updates will be found if Android Market is going to be driving the beta releases.
Expected:
- keep check for updates only for nightly fennec users
Actual:
- check for updates button exist for android fennec beta builds, which theoretically will not have any updates since android update notification engine should drive this
Comment 2•14 years ago
|
||
We can just disable the updater (MOZ_UPDATER=0) for our release builds, while leaving it enabled (MOZ_UPDATER=1) for nightlies.
We will need to go through the front-end code and find places where we need to add #ifdef MOZ_UPDATER
tracking-fennec: ? → 2.0b4+
Assignee | ||
Comment 3•14 years ago
|
||
Would taht (In reply to comment #2)
> We can just disable the updater (MOZ_UPDATER=0) for our release builds, while
> leaving it enabled (MOZ_UPDATER=1) for nightlies.
Would that affect our ability to count ADUs for release builds? Are the ADU metrics based on update pings?
I know the Market gives an an alternate count of "active installations", but that data is not available to the same set of people as metrics.mozilla.org, does not feed to infrastructure like crash-stats, and does not measure the same thing.
Comment 4•14 years ago
|
||
(In reply to comment #3)
> (In reply to comment #2)
> > We can just disable the updater (MOZ_UPDATER=0) for our release builds, while
> > leaving it enabled (MOZ_UPDATER=1) for nightlies.
>
> Would that affect our ability to count ADUs for release builds? Are the ADU
> metrics based on update pings?
That is a good question. I think we use blocklist pings, not update pings.
Maybe Daniel can answer this for us.
Comment 5•14 years ago
|
||
Correct, we currently use blocklist for tracking ADU.
Updated•14 years ago
|
Assignee: nobody → mbrubeck
Assignee | ||
Comment 6•14 years ago
|
||
I've tested this on desktop and Android, with updater enabled and disabled. (I haven't tested that updates actually download and install, since I only ran local builds.)
Attachment #502728 -
Flags: review?(mark.finkle)
Comment 7•14 years ago
|
||
Comment on attachment 502728 [details] [diff] [review]
patch
Looks like you covered all the right spots. We'll need to test this using a special release build before spinning the next beta.
Attachment #502728 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 8•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 9•14 years ago
|
||
Disabling the updater for release builds in the mozconfig in bug 609705.
Comment 10•13 years ago
|
||
Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:7.0)Gecko/20110902
Firefox/7.0 Fennec/7.0
Device: Samsung Galaxy S
OS: Android 2.2
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•