Closed Bug 626279 Opened 14 years ago Closed 8 years ago

Use async bookmarking APIs in Sync

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: philikon, Unassigned)

References

(Depends on 1 open bug)

Details

(Whiteboard: [sync:bookmarks])

+++ This bug was initially created as a clone of Bug #606353 +++
blocking2.0: final+ → ---
tracking-fennec: 2.0b4+ → ---
Blocks: 608617
Blocks: 576651
Whiteboard: [sync:bookmarks]
If I understand correctly, then this will fix the following: bug 1041367, bug 1236234 Also, is this bug covered by bug 1068054 or vice-versa?
Blocks: 697649
This was fixed in bug 1274108, bug 1302288, bug 1302286, and bug 1312226. Annotations and tags are still sync (bug 1295519): there aren't async APIs available for those, and both might be getting overhauls soon. But the bulk of the work is complete, so I think we can close this out.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
There is still code that could probably use Sqlite.jsm http://searchfox.org/mozilla-central/rev/02a56df6474a97cf84d94bbcfaa126979970905d/services/sync/tests/unit/test_places_guid_downgrade.js#50 http://searchfox.org/mozilla-central/search?q=.DBConnection&path=sync I don't know how many of these could be converted, but looks like a mentored bug could help if we figure that out?
Flags: needinfo?(kit)
Definitely. It feels somewhat intimidating for a first bug, but could be a good next bug. We can probably remove `Async.querySpinningly`, switch the tests to use `promiseDBConnection` and `Async.promiseSpinningly`, and move the remaining queries into PlacesSyncUtils. I'll write up a bug with more details and set myself as mentor. Thanks for the suggestion!
Filed bug 1336282 and bug 1336518 for removing the others.
Flags: needinfo?(kit)
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.