Open
Bug 628756
Opened 14 years ago
Updated 10 years ago
Remove nsVoidArray from /Ldap/Xpcom
Categories
(Directory :: LDAP XPCOM SDK, defect)
Directory
LDAP XPCOM SDK
Tracking
(Not tracked)
ASSIGNED
People
(Reporter: sgautherie, Assigned: sgautherie)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
|
(deleted),
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
{
/ldap/xpcom/src/nsLDAPURL.h
* line 43 -- #include "nsVoidArray.h"
/ldap/xpcom/src/nsLDAPService.cpp
* line 169 -- // implemented as a "stack" on top of the nsVoidArrays, since we can
}
|
Assignee | |
Comment 1•12 years ago
|
||
Only 1 left:
{
/ldap/xpcom/src/nsLDAPService.cpp
* line 130 -- // implemented as a "stack" on top of the nsVoidArrays, since we can
}
At first glance, this code was initially added in bug 70422, then modified in bug 177400.
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/directory/xpcom/base/src/nsLDAPService.cpp&rev=1.29#153
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/directory/xpcom/base/src/nsLDAPService.h&rev=1.11#104
***
(Untested :-|)
|
||
Updated•12 years ago
|
Attachment #646184 -
Flags: review?(mbanner) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 646184 [details] [diff] [review]
(Av1) nsLDAPServiceEntry, PopListener() and PushListener(): Fix documentation, Improve code
Ftr, this patch was bitrotted by
http://hg.mozilla.org/comm-central/rev/fd2f5a37ef5f
Bug 859817 - Followup: Fix implicit conversions to already_AddRefed in nsLDAPService.cpp.
Yet, I think a few bits could still (be) apply...
You need to log in
before you can comment on or make changes to this bug.
Description
•