Closed Bug 630518 Opened 14 years ago Closed 13 years ago

l10n verify, update verify, and final verification builders need to set "branch" when reporting to clobberer

Categories

(Release Engineering :: Release Requests, defect, P2)

Product:
Release Engineering
Component:
Release Requests
Platform:
x86_64
Linux
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: rail)

References

Details

(Whiteboard: [automation])

Attachments

(1 file, 1 obsolete file)

use branches
(deleted), patch
bhearsum
: review+
rail
: checked-in+
Details | Diff | Splinter Review
Currently they don't, which is bad for two reasons: 1) It's inconsistent with all the other builders 2) They won't get clobbered when we clobber by branch This isn't high priority because these builders clobber themselves at the start of a build.
Shouldn't be hard, setting branchName should help.
Assignee: nobody → rail
Component: Release Engineering → Release Engineering: Releases
Priority: P4 → P2
QA Contact: release → bhearsum
Attached patch pass repo path (obsolete) (deleted) — — Splinter Review
Not tested yet. Update verify doesn't use clobberer.
Attached patch use branches (deleted) — — Splinter Review
Checking clobber URL: http://build.mozilla.org/stage-clobberer/index.php?master=http%3A%2F%2Fdev-master01.build.scl1.mozilla.com%3A8033%2F&slave=linux-ix-slave04&builddir=rel-m-rel-osx64-fnl-verf&branch=mozilla-release&buildername=release-mozilla-release-macosx64_final_verification Backward compatible patch. If you prefer I can just remove the extra check and make the factories require repoPath.
Attachment #604663 - Attachment is obsolete: true
Attachment #604909 - Flags: review?(bhearsum)
Comment on attachment 604909 [details] [diff] [review] use branches Review of attachment 604909 [details] [diff] [review]: ----------------------------------------------------------------- ::: process/factory.py @@ +5447,5 @@ > def __init__(self, verifyConfigs, platforms=None, **kwargs): > # MozillaBuildFactory needs the 'repoPath' argument, but we don't > + if 'repoPath' not in kwargs: > + kwargs['repoPath'] = 'nothing' > + ReleaseFactory.__init__(self, **kwargs) Do we have any cases where repoPath won't be set here or in l10n verify? What happens to the clobberer data when it gets a branch of 'nothing'? Does it show up on the webpage?
(In reply to Ben Hearsum [:bhearsum] from comment #5) > Do we have any cases where repoPath won't be set here or in l10n verify? No, that's to not force tb, sm, calendar to use the new schema. Probably forcing won't be a bad idea. > What happens to the clobberer data when it gets a branch of 'nothing'? Does > it show up on the webpage? These builders are safe to be run even without clobbering. I couldn't find any special cases for 'nothing' in clobberer nor other places.
Comment on attachment 604909 [details] [diff] [review] use branches Review of attachment 604909 [details] [diff] [review]: ----------------------------------------------------------------- OK, this should be fine then.
Attachment #604909 - Flags: review?(bhearsum) → review+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Reconfiged x2.
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: