John Ford [:jhford] CET/CEST Berlin Time Reporter
	Description • 14 years ago

or it shouldn't do the reconfig at all.

	Rail Aliiev [:rail] Assignee
	Comment 1 • 14 years ago

I'd add --reconfig (default=False).

	bhearsum@mozilla.com (:bhearsum)
	Comment 2 • 14 years ago

Personally, I'd like to see it doing reconfigs still...it's a good safeguard to have. But if that's too difficult to do immediately, disabling them is definitely good.

	Rail Aliiev [:rail] Assignee
	Comment 3 • 14 years ago

Could we use http://hg.mozilla.org/build/braindump/file/391f2a2e2d74/buildbot-related/buildbot-wrangler.py instead of 'buildbot reconfig' here?

	Chris AtLee [:catlee]
	Comment 4 • 14 years ago

If it doesn't do the reconfig, it shouldn't do the sendchange either.

	bhearsum@mozilla.com (:bhearsum)
	Comment 5 • 14 years ago

(In reply to comment #4)
> If it doesn't do the reconfig, it shouldn't do the sendchange either.

I'm not sure I follow....having it do the sendchange is still good IMHO, because it makes it impossible for us to typo in it.

	Chris AtLee [:catlee]
	Comment 6 • 14 years ago

(In reply to comment #5)
> (In reply to comment #4)
> > If it doesn't do the reconfig, it shouldn't do the sendchange either.
> 
> I'm not sure I follow....having it do the sendchange is still good IMHO,
> because it makes it impossible for us to typo in it.

The whole point of release_sanity is to make sure the master is in a good state before kicking things off.  If it doesn't do the reconfig, it doesn't know if the files on disk have any relation to what the master is running.

	bhearsum@mozilla.com (:bhearsum)
	Comment 7 • 14 years ago

I thought the point was to reduce opportunity for manual error. In any case, you seem to feel strongly about this so I'm not going to push back. If it's not doing the sendchange it should at least spit out the "buildbot sendchange" line for you to copy and paste from.

	Chris AtLee [:catlee]
	Comment 8 • 14 years ago

(In reply to comment #7)
> I thought the point was to reduce opportunity for manual error. In any case,
> you seem to feel strongly about this so I'm not going to push back. If it's not
> doing the sendchange it should at least spit out the "buildbot sendchange" line
> for you to copy and paste from.

I think it should be doing both the reconfig and the sendchange.  We just need to add smarts to make sure it waits for the reconfig to finish.

	Rail Aliiev [:rail] Assignee
	Comment 11 • 14 years ago

Worked fine in staging.

	Rail Aliiev [:rail] Assignee
	Comment 12 • 14 years ago

Comment on attachment 516843 [details] [diff] [review]
Use buildbot-wrangler.py for reconfig

http://hg.mozilla.org/build/tools/rev/a1acec433bbb

	Rail Aliiev [:rail] Assignee
	Comment 13 • 14 years ago

Comment on attachment 516842 [details] [diff] [review]
Move buildbot-wrangler.py manage_masters.py master_fabric.py to tools

http://hg.mozilla.org/build/braindump/rev/1b5befc79b85