Closed Bug 631124 Opened 14 years ago Closed 14 years ago

Modules imported in process/release.py should use reload() to be reconfigured properly

Categories

(Release Engineering :: General, defect, P2)

Product:
Release Engineering
Component:
General
Platform:
x86
Linux
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jhford, Assigned: rail)

References

Details

Attachments

(1 file, 2 obsolete files)

reload release.py modules
(deleted), patch
catlee
: review+
rail
: checked-in+
Details | Diff | Splinter Review
Assignee: nobody → rail
Priority: -- → P2
Hardware: x86_64 → x86
Attached patch reload release.py modules (obsolete) (deleted) — — Splinter Review
Looks like the main problem here is the fact that we don't reload modules in release.py. * removed some imported but unused functions * buildbot2ftp(p) instead of ftp_platform_map.get(p, p) * removed unused base_name variable
Attachment #509683 - Flags: review?(catlee)
Comment on attachment 509683 [details] [diff] [review] reload release.py modules Not everything needs to be reloaded here...only things that aren't being reloaded elsewhere. I think just release.platforms and release.paths need to be reloaded here.
Attachment #509683 - Flags: review?(catlee) → review-
Attached patch reload release.py modules (obsolete) (deleted) — — Splinter Review
BuildSlaves also should be reloaded, imo.
Attachment #509683 - Attachment is obsolete: true
Attachment #509687 - Flags: review?(catlee)
Summary: release emails should use mac instead of mac64 → Modules imported in process/release.py should use reload() to be reconfigured properly
Attached patch reload release.py modules (deleted) — — Splinter Review
Attachment #509687 - Attachment is obsolete: true
Attachment #509691 - Flags: review?(catlee)
Attachment #509687 - Flags: review?(catlee)
Attachment #509691 - Flags: review?(catlee) → review+
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: