Closed
Bug 634395
Opened 14 years ago
Closed 14 years ago
Don't trigger TriggerBouncerCheck if push to mirrors fails
Categories
(Release Engineering :: General, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: rail)
References
Details
(Whiteboard: [releases][automation])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
bhearsum
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
In the current implementation ScriptFactory doesn't have haltOnFailure set for run_script step, so TriggerBouncerCheck is triggered even if the previous step fails.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #515595 -
Flags: review?(bhearsum)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 515595 [details] [diff] [review]
Add haltOnFailure parameter to ScriptFactory
In an effort to keep ScriptFactory small and simple I'd suggest that we *always* haltOnFailure if the script fails -- I can't think of a case where this would be undesired.
Attachment #515595 -
Flags: review?(bhearsum) → review-
|
|
Assignee | |
Comment 3•14 years ago
|
||
(In reply to comment #2)
> In an effort to keep ScriptFactory small and simple I'd suggest that we
> *always* haltOnFailure if the script fails -- I can't think of a case where
> this would be undesired.
Sounds quite reasonable.
Attachment #515595 -
Attachment is obsolete: true
Attachment #515603 -
Flags: review?(bhearsum)
|
|
||
Updated•14 years ago
|
Attachment #515603 -
Flags: review?(bhearsum) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Comment on attachment 515603 [details] [diff] [review]
Always haltOnFailure in ScriptFactory
http://hg.mozilla.org/build/buildbotcustom/rev/400e949a156f
Attachment #515603 -
Flags: checked-in+
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•