Closed Bug 635296 Opened 14 years ago Closed 14 years ago

make buildbot.slave.bot.BuildSlave resolve on slaves (temporarily)

Categories

(Release Engineering :: General, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dustin, Assigned: dustin)

References

Details

Attachments

(1 file, 1 obsolete file)

The upgrade to buildbot-0.8.4 requires a change in buildbot.tac, from from buildbot.slave.bot import BuildSlave to from buildslave.bot import BuildSlave Without the slave allocator running, this is going to be a tiresome change to make (and this upgrade is blocking deploying the slave allocator). For unrelated reasons we need to install the buildbot source code as well as buildbot-slave, which means that adding a dummy buildbot.slave.bot module that points to buildslave.bot could be made to work fairly easily. This would de-synchronize the need to upgrade buildbot.tac from the deployment of the new version of Buildbot. Once slave allocator is available everywhere, the patch could be reverted.
Blocks: 631851
Attached patch m635296-buildbot-r1.patch (obsolete) (deleted) — Splinter Review
Attachment #513509 - Flags: review?(bear)
Comment on attachment 513509 [details] [diff] [review] m635296-buildbot-r1.patch r+ pending future bug to remove this requirement after slavealloc is ready to handle the chore
Attachment #513509 - Flags: review?(bear) → review+
Attached patch m635296-buildbot-r2.patch (deleted) — Splinter Review
Sorry -- original version worked fine in place, but didn't include the new fake subpackage in the distribution because it wasn't mentioned in setup.py This version is confirmed to work on a staging slave.
Attachment #513509 - Attachment is obsolete: true
Attachment #513521 - Flags: review?(bear)
Attachment #513521 - Flags: review?(bear) → review+
slaves branch - 0b3e92109b06
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Blocks: 637349
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: