Closed
Bug 636083
Opened 14 years ago
Closed 14 years ago
Don't send "Tagging started" email to r-d for dummy tag factory
Categories
(Release Engineering :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: nthomas, Assigned: rail)
References
Details
(Whiteboard: [releases][automation])
Attachments
(1 file)
(deleted),
patch
|
bhearsum
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
I set skip_tag to True and reran the automation when tagging failed out on me. That worked great except that a second Tagging email was sent to r-d. I'd argue that that's more confusing than useful and should be prevented. Conversely, the tagging complete mail didn't go to r-d, despite the FIXED resolution of bug 635510.
Assignee | ||
Comment 1•14 years ago
|
||
> Conversely, the tagging complete mail didn't go to r-d, despite the FIXED > resolution of bug 635510. That's expected. The "tag" builder ran 2 times for 4.0b12 build1. The first one failed. We don't send "failed" emails to r-d (mode='passing'). The second one (with releaseConfig['skip_tag'] = True) was dummy. Tag builder is not added to notify_builders in this case, see around this line: http://hg.mozilla.org/build/buildbotcustom/file/dd7e3fa9d386/process/release.py#l530 Morphing the title. Patch is on the way.
Assignee: nobody → rail
Blocks: 627271
Summary: Don't send email to r-d for dummy factories → Don't send "Tagging started" email to r-d for dummy tag factory
Whiteboard: [releases][automation]
Assignee | ||
Updated•14 years ago
|
Priority: -- → P2
Assignee | ||
Comment 2•14 years ago
|
||
To be tested in staging.
Attachment #514468 -
Flags: review?(bhearsum)
Updated•14 years ago
|
Attachment #514468 -
Flags: review?(bhearsum) → review+
Assignee | ||
Comment 3•14 years ago
|
||
Comment on attachment 514468 [details] [diff] [review] buildbotcustom http://hg.mozilla.org/build/buildbotcustom/rev/86c637c8f3e4
Attachment #514468 -
Flags: checked-in+
Assignee | ||
Comment 4•14 years ago
|
||
Tested in staging.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•