Closed
Bug 641842
Opened 14 years ago
Closed 14 years ago
Upgrade gcc 4.5 on buildbots
Categories
(Release Engineering :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: glandium, Assigned: rail)
References
Details
Attachments
(2 files)
(deleted),
patch
|
catlee
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
catlee
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
Building current mozilla central with gcc 4.5 from /tools/gcc-4.5 (I believe this is 4.5.1) with the -O3 patch from bug 590181 applied leads to several failures in various tests (most notably plugin failures and some reftest problems). However, this doesn't happen on a local build with either 4.5.2 from Debian (svn revision 170696) or a plain 4.5.2 from upstream gcc.
As a consequence, could you package gcc 4.5.2 and upgrade gcc on the buildbots?
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → rail
Priority: -- → P3
Reporter | ||
Comment 1•14 years ago
|
||
Hold on, this is crazy, I can't even reproduce the problem the buildbots exhibit when I use the binaries from try.
Reporter | ||
Comment 2•14 years ago
|
||
It was pretty dumb... libnptest.so of my try depended on libstdc++ 4.5.
So, now that it's a non issue, do we still want to bump gcc 4.5 version ?
Comment 3•14 years ago
|
||
If you don't need the newer version, then I'd just resolve this INCOMPLETE or WONTFIX.
Reporter | ||
Comment 4•14 years ago
|
||
(In reply to comment #3)
> If you don't need the newer version, then I'd just resolve this INCOMPLETE or
> WONTFIX.
The question was whether there'd be another rationale to push a newer version. Better to bump it before actually switching, if we want to.
Comment 5•14 years ago
|
||
(In reply to comment #4)
> (In reply to comment #3)
> > If you don't need the newer version, then I'd just resolve this INCOMPLETE or
> > WONTFIX.
>
> The question was whether there'd be another rationale to push a newer version.
> Better to bump it before actually switching, if we want to.
agreed. easier to change now than later.
Assignee | ||
Comment 6•14 years ago
|
||
(In reply to comment #5)
> agreed. easier to change now than later.
Yeah, risk is very low. Let's upgrade it.
Priority: P3 → P2
Assignee | ||
Comment 7•14 years ago
|
||
I dropped linux64-ffi.diff patch which exists in 4.5.2.
Attachment #519878 -
Flags: review?(catlee)
Assignee | ||
Comment 8•14 years ago
|
||
some of the staging build slaves got this ;)
Attachment #519879 -
Flags: review?(catlee)
Updated•14 years ago
|
Attachment #519878 -
Flags: review?(catlee) → review+
Updated•14 years ago
|
Attachment #519879 -
Flags: review?(catlee) → review+
Reporter | ||
Comment 9•14 years ago
|
||
Please hold on before building and deploying with this spec file. I may have a request for some specific build flags.
Assignee | ||
Comment 10•14 years ago
|
||
(In reply to comment #9)
> Please hold on before building and deploying with this spec file. I may have a
> request for some specific build flags.
Sure.
Reporter | ||
Comment 11•14 years ago
|
||
Turns out the flags I was interested in are used by default, so you can go ahead :)
Assignee | ||
Comment 12•14 years ago
|
||
Comment on attachment 519878 [details] [diff] [review]
RPM spec changes
http://hg.mozilla.org/build/rpm-sources/rev/44f2e9f4c65f
Attachment #519878 -
Flags: checked-in+
Assignee | ||
Comment 13•14 years ago
|
||
Comment on attachment 519879 [details] [diff] [review]
puppet
http://hg.mozilla.org/build/puppet-manifests/rev/19af7fd3219d
Attachment #519879 -
Flags: checked-in+
Assignee | ||
Comment 14•14 years ago
|
||
gcc-4.5.2 deployment has just started. I'll check the result tomorrow.
Assignee | ||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 15•14 years ago
|
||
Is it possible to get the resulting rpm ?
Assignee | ||
Comment 16•14 years ago
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•