Closed
Bug 642450
Opened 14 years ago
Closed 13 years ago
Fail to run tests when firefox-bin is not a file
Categories
(Release Engineering :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: glandium, Assigned: coop)
References
Details
(Whiteboard: [unittest])
Attachments
(1 file)
(deleted),
patch
|
catlee
:
review+
coop
:
checked-in+
|
Details | Diff | Splinter Review |
Part of bug 552864, we're getting rid of the firefox-bin binary, though we actually keep a symbolic link for compatibility purposes. Doing so works fine on Linux builds and tests, but fails on OSX, where the buildbot runs the following command: find . -maxdepth 4 -type f -name firefox-bin Since firefox-bin is a symbolic link, that doesn't match and the test fails. There are apparently two places in process/factory.py where this is done: - http://hg.mozilla.org/build/buildbotcustom/file/48a72b08bb38/process/factory.py#l6572 - http://hg.mozilla.org/build/buildbotcustom/file/48a72b08bb38/process/factory.py#l7219 Maybe there are other places, though. Removing filetype as in the attached patch should be enough to make it work before and after landing.
Attachment #519909 -
Flags: review?(catlee)
Updated•14 years ago
|
Whiteboard: [unittest]
Updated•14 years ago
|
Attachment #519909 -
Flags: review?(catlee) → review+
Assignee | ||
Updated•14 years ago
|
Priority: -- → P3
Assignee | ||
Updated•14 years ago
|
Attachment #519909 -
Flags: checked-in?
Assignee | ||
Comment 1•13 years ago
|
||
I'll make sure this gets landed.
Assignee: nobody → coop
Status: NEW → ASSIGNED
Priority: P3 → P2
Assignee | ||
Comment 2•13 years ago
|
||
Comment on attachment 519909 [details] [diff] [review] Don't search firefox-bin with a file type http://hg.mozilla.org/build/buildbotcustom/rev/7090913d8109
Attachment #519909 -
Flags: checked-in? → checked-in+
Assignee | ||
Comment 3•13 years ago
|
||
In production now.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•