Closed
Bug 64543
Opened 24 years ago
Closed 23 years ago
"Warn me before storing a cookie" should be "Ask me ..."
Categories
(Core :: Networking: Cookies, defect)
Core
Networking: Cookies
Tracking
()
RESOLVED
FIXED
mozilla0.9.8
People
(Reporter: jag+mozbugs, Assigned: jmd)
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
morse
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
Or "Alert me before downloading an image" should be "Warn me ..."
In preferences -> advanced -> [cookies|images]
Comment 1•24 years ago
|
||
I vote for "Alert me..". It's more clear that we're going to show an alert
then.. to be honest I don't really care, but "Alert me.." is more clear.
Comment 2•24 years ago
|
||
Users don't know what alerts are, if that's what this is supposed to be
referring to. I didn't, until I started programming for Mozilla...
Comment 3•24 years ago
|
||
Users don't have to know what alerts are, in order to know what `alert me' means.
It's also slightly more accurate than `warn me', because the relevant dialogs
allow the user to accept or reject the image or cookie -- they don't just provide
a warning.
Comment 4•24 years ago
|
||
I was responding to Hwaara:
"I vote for "Alert me..". It's more clear that we're going to show an alert
then"
Updated•24 years ago
|
Target Milestone: --- → Future
Comment 6•24 years ago
|
||
Umm, how about "Ask me..."?
Comment 7•24 years ago
|
||
Yeah, good idea. Also, the cookies panel should change its text to be consistent
if we fix this. Is this okay with you all?
Comment 8•24 years ago
|
||
Yup.
Updated•24 years ago
|
Status: NEW → ASSIGNED
Comment 9•23 years ago
|
||
Moving to cookies.
Status: ASSIGNED → NEW
Component: Preferences → Cookies
QA Contact: sairuh → tever
Updated•23 years ago
|
Blocks: patchmaker
Comment 10•23 years ago
|
||
Interestingly under the image preferences it says "Alert me...". This should be
made consistent. I vote for "Ask me..".
Assignee | ||
Comment 11•23 years ago
|
||
Taking. Have a patch. Changed both to 'ask', as suggested by bnesse and mpt.
Also some accesskey lovin, even though accesskeys aren't really enabled on most
objects in pref panes.
Assignee: morse → mozilla
Assignee | ||
Comment 12•23 years ago
|
||
Assignee | ||
Comment 13•23 years ago
|
||
Eliminated two duplicate accesskeys. The Enabled -> Accept change should be a
clear win, as well (mpt agreed). Need r/sr.
Attachment #62730 -
Attachment is obsolete: true
Comment 14•23 years ago
|
||
Please use "Alert me..." to be consistent with other panels. We need consistency
between the image/cookies etc. panels in this aspect.
Assignee | ||
Comment 15•23 years ago
|
||
Consistency with what, exactly?
Offline & Diskspace uses 'ask', THREE times.
Master password uses 'ask'
SSL Warnings uses 'alert', but those do seem to be alerts. They're not questions.
Mail News->Send Format uses 'ask'
So 'ask' certainly seems to be the choice.
Comment 16•23 years ago
|
||
Jeremy: In the future when you reassign a bug to yourself please add the
original assignee to the cc list so he will continue to get updates to the bug
report.
Comments on patch:
1. Why did you change "enable all cookies" to "accept all cookies", yet you left
"Enable cookies from originating web site only" as is?
2. The wording was intentionally changed from "accept" to "enable" a while ago
because it involves not only "accepting" of cookies but also resending of
cookies back to the website.
Assignee | ||
Comment 17•23 years ago
|
||
> In the future when you reassign a bug to yourself please
Will do. Sorry.
As for Enable->Accept, it sounded a lot clearer, more accurate, and consistent
with "accept images" in the image prefs. I ran it by mpt, and he agreed. But
you're right, Enable technically includes resending as well, although this is
certainly beyond 'not clear' to users that don't understand HTTP. I think they
are both less the ideal... perhaps accept is also technically correct, as it
would be natural to assume unless it's on the disabled setting, cookies already
accepted are sent. It's a debateable issue for another bug, I'll take out that
change.
The rest shouldn't be controversial, assuming we agree on using "Ask".
Comment 18•23 years ago
|
||
r=morse (with "accept" changed back to "enable")
Assignee | ||
Comment 19•23 years ago
|
||
Attachment #62732 -
Attachment is obsolete: true
Updated•23 years ago
|
Attachment #62736 -
Flags: review+
Assignee | ||
Comment 20•23 years ago
|
||
Does this need an sr?
Status: NEW → ASSIGNED
Target Milestone: Future → mozilla0.9.8
Comment 21•23 years ago
|
||
Comment on attachment 62736 [details] [diff] [review]
Only "warn/alert -> ask", and accesskey fixes
sr=jag
Attachment #62736 -
Flags: superreview+
Assignee | ||
Comment 22•23 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Summary: "Warn me before storing a cookie" should be "Alert me ..." → "Warn me before storing a cookie" should be "Ask me ..."
Comment 23•23 years ago
|
||
I think we are past time to be tweaking random prefs for slightly better
wording; wording tweaks are no longer the trivial acts they once were, they now
have consequences.
For example, help content is now outdated; it still says "Warn." Cc'ing jatin.
And the instructions at bankofamerica.com
(http://www.bankofamerica.com/state.cgi?section=signin&update=&cookiecheck=yes)
now incorrectly point to a checkbox that says "Warn." It took me a little time
to find this checkbox, and I was about to give up, thinking it had been removed.
It is possible that in this case the change was worth it. "Warn" is a pretty
big and important difference from "Ask." I'm just asking that we consider
changes more in the future.
Assignee | ||
Comment 24•23 years ago
|
||
> I think we are past time to be tweaking random prefs for slightly better wording
Unfortunatly, nobody bothers with the polish until it's too late.
> And the instructions at bankofamerica.com
Actually, that page gives me Netscape 4.x directions for Mozilla non-commercial:
"It appears that you are using Netscape version 4.0 or greater, but less than
version 6.0. To use our Web site more effectively, you can enable cookies by
following these steps:"
Besides, anyone who went out of their way to disable cookies likely can figure
out how to turn them back on.
You're right though, wording changes to obsolete documentation, including some
we don't control, but we ARE still pre-1.0. It's something to keep in mind for
the stable branches...
Updated•23 years ago
|
No longer blocks: patchmaker
You need to log in
before you can comment on or make changes to this bug.
Description
•