Closed
Bug 649463
Opened 14 years ago
Closed 14 years ago
Do not test the kVirtualGCTrace bit if exactgc is disabled at compile time
Categories
(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P3)
Tamarin Graveyard
Garbage Collection (mmGC)
Tracking
(Not tracked)
RESOLVED
FIXED
Q3 11 - Serrano
People
(Reporter: lhansen, Assigned: lhansen)
References
Details
(Whiteboard: has-patch)
Attachments
(1 file)
|
(deleted),
patch
|
rulohani
:
review+
|
Details | Diff | Splinter Review |
This small adjustment makes performance comparisons slightly more honest.
Attachment #525470 -
Flags: review?(rulohani)
|
Assignee | |
Updated•14 years ago
|
Whiteboard: has-patch
|
||
Updated•14 years ago
|
Attachment #525470 -
Flags: review?(rulohani) → review+
|
|
Assignee | |
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Comment 1•14 years ago
|
||
changeset: 6180:d30afa6b9ca3
user: Lars T Hansen <lhansen@adobe.com>
summary: Fix 649463 - Do not test the kVirtualGCTrace bit if exactgc is disabled at compile time (r=rulohani)
http://hg.mozilla.org/tamarin-redux/rev/d30afa6b9ca3
|
||
Comment 2•14 years ago
|
||
Disabling exact tracing fails to compile cleanly on windows since "warnings as errors" are enabled for windows and there is an "unreferenced formal parameter" @ MMgc\GC-inlines.h:437
This warning is also generated on mac but warnings as errors are not enabled when compiling using ../configure.py
|
|
||
Comment 3•14 years ago
|
||
(In reply to comment #2)
> Disabling exact tracing fails to compile cleanly on windows since "warnings as
> errors" are enabled for windows and there is an "unreferenced formal parameter"
> @ MMgc\GC-inlines.h:437
>
> This warning is also generated on mac but warnings as errors are not enabled
> when compiling using ../configure.py
This only happens IF -DAVMTWEAK_EXACT_TRACING=0 is defined, it is NOT seen in normal configurations
|
|
Assignee | |
Comment 4•14 years ago
|
||
(In reply to comment #3)
> (In reply to comment #2)
> > Disabling exact tracing fails to compile cleanly on windows since "warnings as
> > errors" are enabled for windows and there is an "unreferenced formal parameter"
> > @ MMgc\GC-inlines.h:437
> >
> > This warning is also generated on mac but warnings as errors are not enabled
> > when compiling using ../configure.py
>
> This only happens IF -DAVMTWEAK_EXACT_TRACING=0 is defined, it is NOT seen in
> normal configurations
I have pushed a fix (without testing it).
You need to log in
before you can comment on or make changes to this bug.
Description
•