Closed
Bug 652553
Opened 14 years ago
Closed 6 years ago
When reviewing a patch, there is redundant data in the bug comment
Categories
(bugzilla.mozilla.org :: Splinter, defect, P5)
Tracking
()
RESOLVED
INCOMPLETE
People
(Reporter: LpSolit, Assigned: dkl)
References
Details
See e.g. bug 652405 comment 4:
"Comment on attachment 527996 [details] [diff] [review]
patch, v1
Review of attachment 527996 [details] [diff] [review]:
Looks good to me. r=dkl"
The comment should be either (bmo 3.6, also upstream):
"Comment on attachment 527996 [details] [diff] [review]
patch, v1
Looks good to me. r=dkl"
*OR*
"Review of attachment 527996 [details] [diff] [review]:
patch, v1
Looks good to me. r=dkl"
Assignee | ||
Comment 1•14 years ago
|
||
Thanks. I will look at that. I did actually use Splinter to review and comment on the patch which is an extension of BMO.
dkl
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Component: Bugzilla: Other b.m.o Issues → Splinter
Product: mozilla.org → bugzilla.mozilla.org
QA Contact: other-bmo-issues → bmo-splinter
Version: other → Current
Assignee | ||
Comment 2•14 years ago
|
||
This will be addressed but since Splinter is new for 4.0, I don't think it necessarily needs to be on the regression blocker.
dkl
No longer blocks: bmo-regressions
Assignee | ||
Comment 4•13 years ago
|
||
I will look into somehow hooking in and replacing "Comment on an attachment XXXX"
and changing it to "Review of attachment XXXX" which can then be used by the Splinter javascript code to key off of. Splinter is currently using the extra line that has "Review of ...." with the ------ under to recognize a bug comment as a Splinter review and pulling out the hunks to recreate the previous review. I need to maintain that functionality with whatever change I make.
dkl
Updated•8 years ago
|
Priority: -- → P5
Comment 5•6 years ago
|
||
Splinter is retiring.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•