bhearsum@mozilla.com (:bhearsum) Reporter
	Description • 14 years ago

I did part of staging release today and a AV vendor e-mail went to release@mozilla.com. This is good, but the subject is confusing. In staging/preproduction it would be helpful to tag them the same way we do other release mails: with [staging] or [preprod-release].

	bhearsum@mozilla.com (:bhearsum) Reporter
	Comment 1 • 13 years ago

Mass move of bugs to Release Automation component.

	bhearsum@mozilla.com (:bhearsum) Reporter
	Comment 3 • 12 years ago

Comment on attachment 669926 [details] [diff] [review]
patch for bug 656286

This looks OK, but let's make sure the behaviour in consistent with similar options in createReleaseMessage by factoring out to getSubject() and getMessageTag():
https://github.com/mozilla/buildbotcustom/blob/master/process/release.py#L164
https://github.com/mozilla/buildbotcustom/blob/master/process/release.py#L205

	Massimo Gervasini [:massimo] Assignee
	Comment 4 • 12 years ago

added getMessageTag()

	bhearsum@mozilla.com (:bhearsum) Reporter
	Comment 5 • 12 years ago

Comment on attachment 672540 [details] [diff] [review]
added getMessageTag()

Review of attachment 672540 [details] [diff] [review]:
-----------------------------------------------------------------

::: process/release.py
@@ +271,5 @@
> +    def getMessageTag():
> +        return releaseConfig.get('messagePrefix', '[release] ')
> +
> +    def getSubject():
> +        subject = getMessageTag() + '%(productName)s %(version)s release'

We should actually drop this, since it's not used everywhere, and put this assignment create in createReleaseAVVendorsMessage. Looks fine otherwise.

	bhearsum@mozilla.com (:bhearsum) Reporter
	Comment 6 • 12 years ago

Comment on attachment 672540 [details] [diff] [review]
added getMessageTag()

Need the below addressed, removing review.

::: process/release.py
@@ +271,5 @@
> +    def getMessageTag():
> +        return releaseConfig.get('messagePrefix', '[release] ')
> +
> +    def getSubject():
> +        subject = getMessageTag() + '%(productName)s %(version)s release'

We should actually drop this, since it's not used everywhere, and put this assignment create in createReleaseAVVendorsMessage. Looks fine otherwise.

	Massimo Gervasini [:massimo] Assignee
	Comment 7 • 12 years ago

resending patch. In the last upload I have sent the wrong one. My fault.

	bhearsum@mozilla.com (:bhearsum) Reporter
	Comment 8 • 12 years ago

Comment on attachment 673961 [details] [diff] [review]
patch for 656286

Review of attachment 673961 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good now, thanks! I landed this on the default branch.

	Rail Aliiev [:rail]
	Comment 9 • 12 years ago

In production