tracking bug for the removal of all places in sut_tools and buildbotcustom where org.mozilla.fennec is hardcodeed

Comment on attachment 531710 [details] [diff] [review] buildbot-configs change for branch based process names buildbotcustom.steps.talos.MozillaUpdateConfig has the branchName, so this should work with some logic there. I believe mozilla-beta is org.mozilla.firefox_beta and we'll need to add mozilla-release -> org.mozilla.firefox .

Comment on attachment 531711 [details] [diff] [review] change remote talos to use processName and add remoteExtras to remote unittests This looks right, but where does the unit test factory get the remote extras from ? (Needs a config patch?)

(In reply to comment #4) > Comment on attachment 531711 [details] [diff] [review] [review] > change remote talos to use processName and add remoteExtras to remote > unittests > > This looks right, but where does the unit test factory get the remote extras > from ? (Needs a config patch?) yea, i'm still chewing on it but wanted to get it to you for feedback to make sure I wasn't driving off the road with this change

add remoteExtras bit for unittests

Comment on attachment 531889 [details] [diff] [review] buildbot-configs change for branch based process names Review of attachment 531889 [details] [diff] [review]: ----------------------------------------------------------------- ::: mozilla-tests/config.py @@ +13,5 @@ > +REMOTE_PROCESS_NAMES = { 'default': 'org.mozilla.fennec', > + 'mozilla-beta': 'org.mozilla.fennec_beta', > + 'mozilla-aurora': 'org.mozilla.fennec_aurora', > + } > + mozilla-beta == org.mozilla.firefox_beta

(In reply to comment #8) > Comment on attachment 531889 [details] [diff] [review] [review] > buildbot-configs change for branch based process names > > Review of attachment 531889 [details] [diff] [review] [review]: > ----------------------------------------------------------------- > > ::: mozilla-tests/config.py > @@ +13,5 @@ > > +REMOTE_PROCESS_NAMES = { 'default': 'org.mozilla.fennec', > > + 'mozilla-beta': 'org.mozilla.fennec_beta', > > + 'mozilla-aurora': 'org.mozilla.fennec_aurora', > > + } > > + > > mozilla-beta == org.mozilla.firefox_beta changed - thanks for catching that

Comment on attachment 531889 [details] [diff] [review] buildbot-configs change for branch based process names (In reply to comment #3) > I believe mozilla-beta is org.mozilla.firefox_beta and we'll need to add > mozilla-release -> org.mozilla.firefox . As Joel noted, this is still true. Looks like this will work, though.

Comment on attachment 531890 [details] [diff] [review] change remote talos to use processName and add remoteExtras to remote unittests Needs testing, but I think this may work.

Comment on attachment 531889 [details] [diff] [review] buildbot-configs change for branch based process names r=me with the org.mozilla.fennec_beta -> org.mozilla.firefox_beta change and 'mozilla-release': 'org.mozilla.firefox',

currently being tested on staging for both m-c and m-a sendchanges

Comment on attachment 533032 [details] [diff] [review] changes to cleanup.py and installApp.py to work with new process names >+processNames = [ 'org.mozilla.fennec', >+ 'org.mozilla.fennec_aurora', >+ 'org.mozilla.fennec_beta', As noted several times above, this should be org.mozilla.firefox_beta and you should add 'org.mozilla.firefox'. >+ #status = dm.updateApp(target, processName=processName, ipAddr=proxyIP, port=proxyPort) >+ #if status is not None and status: >+ # print "updateApp() call returned %s" % status >+ status = dm.installApp(target) We haltOnFailure on cleanup.py, so not uninst'ing first is fine here. >- pid = dm.processExist('org.mozilla.fennec') >+ pid = dm.processExist(processName) > print 'org.mozilla.fennec PID', pid NIT: maybe |print %s PID' % processName, pid| ? Marking r- to get your attention about firefox_beta :)

Comment on attachment 533041 [details] [diff] [review] changes to cleanup.py and installApp.py to work with new process names Thanks Bear!

fixed list of processNames and also brought it up to date with what I had tweaked while testing on staging

added the processName parameter to remote mochitest as well as the original list, fixed a couple bugs found while doing staging tests

Comment on attachment 533679 [details] [diff] [review] change remote talos to use processName and add remoteExtras to remote unittests committed changeset 1539:4faac6e54f22

Comment on attachment 533677 [details] [diff] [review] buildbot-configs change for branch based process names committed changeset 4124:05feb881375c

Comment on attachment 533041 [details] [diff] [review] changes to cleanup.py and installApp.py to work with new process names committed changeset 1434:7d95d5f68756

Comment on attachment 535000 [details] [diff] [review] bustage fix - use lower case branch name to search dictionary As mentioned in IRC, branchName is actually the name of the tinderbox page; we should pass in branch from generateTalosBranchObjects. And ugh.

staging caught that I missed one location that needs the proper processname - the MozillaUpdateConfig() call for talos.

Comment on attachment 535152 [details] [diff] [review] bustage fix - use proper branch name for talos test runs committed changeset 1555:3f888fb91eda

reconfig landed - marking as fixed