Need new entries in masters json, slavealloc, and puppet manifests.

json for the new masters. I added some new keys to make setup and management easier: "environment", "buildbot_*"

to help review attachment 533486 [details] [diff] [review], here's a diff against the current production-masters.json that has been 'normalized' (sorted by master name, and then the keys in each master sorted)

as part of the above, I wrote some tools to help manipulate the master json: - add-master.py to add a new master to the json - check-master-json.py to validate the contents of the json - normalize-masters.py to sort the json I also made buildbot-wrangler a bit more verbose, and added the ability to update buildbot itself with fabric

in direct contravention of what I said we should do in bug 656003, I think ensure => latest is the only thing we can do here. The old versions aren't always available via yum, and so without controlling our own repos, having specific versions in the manifests is a bug waiting to happen.

Comment on attachment 534038 [details] slavealloc csv for new masters bm11-tests1,buildbot-master11.build.scl1.mozilla.com,8201,9201,scl1,tests-sjc1 bm12-build1,buildbot-master12.build.scl1.mozilla.com,8001,9001,scl1,build-sjc1 bm13-build1,buildbot-master13.build.scl1.mozilla.com,8001,9001,scl1,build-sjc1 bm14-try1,buildbot-master14.build.scl1.mozilla.com,8101,9101,scl1,try-sjc1 these should be tests-scl1, build-scl1, and try-scl1, right?

yes!

In the json file, they were scj1 instead of sjc1

also fix the dbname and hostname with scj vs sjc

Comment on attachment 541459 [details] [diff] [review] Set up self-serve agent on bm10 using puppet Why not use the virtualenv define to set up the virtualenv for selfserve? See the buildslave install stuff for an example. Also, it's generally best to be explicit when invoking a virtualenv -- bin/python buildapi/buildapi/scripts/selfserve-agent.py -f selfserve-agent.ini rather than using bin/activate within a script - activate is really only meant for interactive use.

Comment on attachment 543199 [details] [diff] [review] Set up self-serve agent on bm10 using puppet I'm a little worried about this: + # For virtualenv + "/tools": + ensure => directory, + mode => 755, + owner => "root", + group => "root"; but it's easy enough to move when the time comes.

all done here!