Closed
Bug 656954
Opened 14 years ago
Closed 14 years ago
Add defaultPrevented to nsIDOMEvent
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
FIXED
mozilla6
People
(Reporter: smaug, Assigned: smaug)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
(deleted),
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
We have non-standard getPreventDefault() in nsIDOMNSEvent, but we should
deprecate that at some point and start using defaultPrevented.
But first, implement defaultPrevented.
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #532339 -
Flags: review?(jonas)
Attachment #532339 -
Flags: review?(jonas) → review+
Assignee | ||
Comment 2•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 3•14 years ago
|
||
Comment on attachment 532339 [details] [diff] [review]
patch
(just took a look at the changeset on m-c out of curiosity)
> +is(e.defaultPrevented, false,
> + "After creating event defaultPrevented should be true");
Was the second line supposed to be "After creating event defaultPrevented should be _false_" ? ;)
Assignee | ||
Comment 4•14 years ago
|
||
yes!
I'll fix that.
Assignee | ||
Comment 5•14 years ago
|
||
Assignee | ||
Updated•14 years ago
|
Keywords: dev-doc-needed
Assignee: nobody → Olli.Pettay
Flags: in-testsuite+
Target Milestone: --- → mozilla6
Comment 6•14 years ago
|
||
Documentation added:
https://developer.mozilla.org/en/DOM/event.defaultPrevented
Updated:
https://developer.mozilla.org/en/DOM/event.preventDefault
https://developer.mozilla.org/en/DOM/event
Mentioned on Firefox 6 for developers.
Updated•14 years ago
|
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•