Closed
Bug 714601
Opened 13 years ago
Closed 12 years ago
Use defaultPrevented instead of the deprecated getPreventDefault() in xul/content/static.js
Categories
(Other Applications :: ChatZilla, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dao, Assigned: rginda)
References
Details
(Whiteboard: [cz-0.9.90.1])
Attachments
(2 files, 1 obsolete file)
|
(deleted),
patch
|
bugzilla-mozilla-20000923
:
review-
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
bugzilla-mozilla-20000923
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #707677 +++
event.getPreventDefault is deprecated, we should use event.defaultPrevented instead.
|
||
Comment 1•12 years ago
|
||
As far as I can tell this is all that needs to be done.
|
||
Comment 2•12 years ago
|
||
Comment on attachment 659520 [details] [diff] [review]
Replaces deprecated method
It looks like Donald's patch still applies.
Attachment #659520 -
Flags: review?(rginda)
|
||
Comment 3•12 years ago
|
||
In general ChatZilla tries to maintain backwards compatibility, how deprecated is the method - and how far back does support for the property go?
|
||
Comment 4•12 years ago
|
||
Comment on attachment 659520 [details] [diff] [review]
Replaces deprecated method
(In reply to Glen Mailer from comment #3)
> In general ChatZilla tries to maintain backwards compatibility, how
> deprecated is the method - and how far back does support for the property go?
Gecko 6.0 according to https://developer.mozilla.org/en-US/docs/DOM/event.defaultPrevented . So this patch won't be good enough, sadly. :-(
Attachment #659520 -
Flags: review?(rginda) → review-
|
||
Comment 5•12 years ago
|
||
Patch with polyfill
Attachment #659520 -
Attachment is obsolete: true
Attachment #751684 -
Flags: review?(gijskruitbosch+bugs)
|
|
||
Comment 6•12 years ago
|
||
Personally, I'm not a fan of prototype messing-abouts, and would prefer something like this. I'll leave it to James to decide.
Attachment #752049 -
Flags: review?(silver)
|
|
||
Updated•12 years ago
|
Attachment #751684 -
Flags: review?(gijskruitbosch+bugs) → review?(silver)
|
||
Comment 7•12 years ago
|
||
Comment on attachment 751684 [details] [diff] [review]
Replaces deprecated method, v2
Even AMO's unreliable checks will probably cry over this method too.
Attachment #751684 -
Flags: review?(silver) → review-
|
|
||
Updated•12 years ago
|
Attachment #752049 -
Flags: review?(silver) → review+
|
|
||
Comment 8•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.91]
|
|
||
Updated•10 years ago
|
Whiteboard: [cz-0.9.91] → [cz-0.9.90.1]
You need to log in
before you can comment on or make changes to this bug.
Description
•