Closed Bug 663274 Opened 14 years ago Closed 13 years ago

Restrict OrangeFactor to [orange] bugs

Categories

(Tree Management Graveyard :: OrangeFactor, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ehsan.akhgari, Assigned: jgriffin)

Details

Attachments

(1 file)

Ehsan, can you explain what you mean by unrelated?
(In reply to comment #1) > Ehsan, can you explain what you mean by unrelated? Usually, we denote randomorange bugs by adding [orange] to their status whiteboard. I'm not sure how Orange Factor finds the bug numbers, but clearly there's something broken there, since these bugs are not randomorange bugs.
(In reply to comment #2) > (In reply to comment #1) > > Ehsan, can you explain what you mean by unrelated? > > Usually, we denote randomorange bugs by adding [orange] to their status > whiteboard. I'm not sure how Orange Factor finds the bug numbers, but > clearly there's something broken there, since these bugs are not > randomorange bugs. Ah! OrangeFactor lists bugs that have been used in TBPL star comments. It doesn't restrict them to [orange] bugs, but we could. Should we do that?
Yes! Although, I find it kind of strange. Does this mean that bug 468736 has been mentioned 153 times in TBPL comments?
(In reply to comment #4) > Yes! > > Although, I find it kind of strange. Does this mean that bug 468736 has > been mentioned 153 times in TBPL comments? Indeed it has, in the context of Jetpack SDK tests.
Summary: Orange Factor lists unrelated bugs → Restrict OrangeFactor to [orange] bugs
That few? Well, I guess it was only recently that I got corrected from what I was using before on the every-single-damn-push two Windows debug failures.
Assignee: nobody → jgriffin
(In reply to comment #5) > (In reply to comment #4) > > Yes! > > > > Although, I find it kind of strange. Does this mean that bug 468736 has > > been mentioned 153 times in TBPL comments? > > Indeed it has, in the context of Jetpack SDK tests. Bah. We definitely don't want those bugs to skew our notion of random oranges in the tree. Can we also make sure that we only look at non-hidden machines on Tinderbox?
Attached patch woo_server.py patch v0.1 (deleted) — Splinter Review
This patch causes BugData to return only oranges whose bugs have '[orange]' in their whiteboard field. This reduces the number of failures tracked by WOO from 1123 to 903 (for mozilla-central), at the time of this writing. No JS-code changes are needed.
Attachment #539645 - Flags: review?(mcote)
Comment on attachment 539645 [details] [diff] [review] woo_server.py patch v0.1 Cool cool.
Attachment #539645 - Flags: review?(mcote) → review+
I've deployed this change. Still looking at: > Can we also make sure that we only look at non-hidden > machines on Tinderbox?
You'll want to just keep on looking until that data migrates off tinderbox, because right now your only way to access it is to scrape the output of tinderbox.m.o/admintree.cgi
(In reply to comment #11) > You'll want to just keep on looking until that data migrates off tinderbox, > because right now your only way to access it is to scrape the output of > tinderbox.m.o/admintree.cgi I was thinking we could parse the hiddenBuilds list from http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/file/tip/js/Config.js; do you think that mechanism of flagging hidden builds will be changing?
Yeah: that list never really worked out, nor could it work out, since actually hiding only involves having the sheriffpass and loading a web page, while changing that list involves cloning tbpl, writing a patch, getting review, pushing the patch, filing for a tbpl.m.o update, and getting someone to update the site. From a quick glance, it features some but not all of the currently hidden things, some things which are no longer hidden, and some things that I think no longer exist. That list was updated in mid-May, and again on the first of June, while since last Friday, I've hidden and unhidden a half-dozen things on multiple trees. That list isn't "hidden on tbpl," it's "someone with a tbpl tree got annoyed by seeing these things as pending/running when they knew they would (or did, at some time in the past) disappear as they finished." Among other things, it doesn't include the Valgrind builds, because they don't show up as pending/running and the only reason that list exists is to hide things that show up there. What you want is the eventual fruits of bug 630537.
(In reply to comment #13) > > What you want is the eventual fruits of bug 630537. Cool, thanks, I'll wait for that to land.
Depends on: 630537
WOO now only displays bugs with a whiteboard of [orange]. The other request about filtering out hidden builders has been split off into a separate bug, bug 668117.
Status: NEW → RESOLVED
Closed: 13 years ago
No longer depends on: 630537
Resolution: --- → FIXED
Product: Testing → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: