Closed
Bug 664355
Opened 13 years ago
Closed 13 years ago
Maintain view selection and position across nodes for Computed Style viewer
Categories
(Other Applications :: DOM Inspector, enhancement)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: crussell, Assigned: crussell)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #539410 -
Flags: review?(neil)
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #539412 -
Flags: review?(neil)
|
||
Updated•13 years ago
|
Attachment #539410 -
Flags: review?(neil) → review+
|
|
||
Comment 2•13 years ago
|
||
Comment on attachment 539410 [details] [diff] [review]
computedStyle.js cleanup
>+ get uid()
>+ {
>+ return "computedStyle"
>+ },
>
>+ get pane()
>+ {
>+ return this.mPane
>+ },
>+
>+ get subject()
>+ {
>+ return this.mSubject
>+ },
Please add some ;s
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 539412 [details] [diff] [review]
copy selection stuff and position across views
In theory if you could update the view to look at the new object, you would only have to invalidate the value column.
Attachment #539412 -
Flags: review?(neil) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
(In reply to comment #3)
> Comment on attachment 539412 [details] [diff] [review] [review]
> copy selection stuff and position across views
>
> In theory if you could update the view to look at the new object, you would
> only have to invalidate the value column.
True, but I don't like that it's not conceptually pure.
(In reply to comment #2)
> Please add some ;s
Pushed with that change:
http://hg.mozilla.org/dom-inspector/rev/8125b6d010ad
Also:
http://hg.mozilla.org/dom-inspector/rev/2d0a1137bcc6
You need to log in
before you can comment on or make changes to this bug.
Description
•