Closed
Bug 669722
Opened 13 years ago
Closed 13 years ago
update-verify-bump.pl incorrectly removes the previous release when oldVersion=5.0
Categories
(Release Engineering :: General, defect, P2)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: Callek)
References
Details
(Whiteboard: [release-process-improvement][automation][updates])
Attachments
(1 file)
|
(deleted),
patch
|
bhearsum
:
review+
Callek
:
checked-in+
|
Details | Diff | Splinter Review |
We check the first line of an update verify to see if we need to remove the previous version before bumping. The first line is a comment with the version of previous release. This all worked fine until recently, when we've stopped using the "rc" moniker in version numbers. Now, when this comparison happens, it matches, because eg, "# 5.0b7 - linux" =~ "5.0" is true:
if ($origFile[0] =~ $oldVersion)
The simple fix for this is getting pickier about what we match here. Better fix would be checking the actual data line's version/buildid, might not be worth the trouble though.
|
||
Updated•13 years ago
|
OS: Linux → All
Priority: -- → P3
Hardware: x86_64 → All
Whiteboard: [release-process-improvement][automation][updates]
|
||
Updated•13 years ago
|
Blocks: hg-automation
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → bugspam.Callek
Priority: P3 → P2
|
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #596489 -
Flags: review?(bhearsum)
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 596489 [details] [diff] [review]
v1
Review of attachment 596489 [details] [diff] [review]:
-----------------------------------------------------------------
Yup, I think this works...
Attachment #596489 -
Flags: review?(bhearsum) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 596489 [details] [diff] [review]
v1
http://hg.mozilla.org/build/tools/rev/5be9351f1e0b
Attachment #596489 -
Flags: checked-in+
|
|
Assignee | |
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•