Tracking mozmill test creation for installing a theme. Litmus test: https://litmus.mozilla.org/show_test.cgi?id=15439

A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/15951581

Initial patch

Comment on attachment 546752 [details] [diff] [review] patch v1.0 Review of attachment 546752 [details] [diff] [review]: -----------------------------------------------------------------

Comment on attachment 546752 [details] [diff] [review] patch v1.0 >+const THEME = { >+ name: "LavaFox V1-Green", >+ id: "zigboom@ymail.com", >+ url: addons.AMO_PREVIEW_SITE + "/firefox/addon/lavafox-v1-green/" >+}; I feel that we should get our own theme uploaded to our litmus-data repository or even on AMO. Themes can change a lot and could cause regressions in our tests. >+function teardownModule() { >+ addonsManager.close(); >+ >+ delete persisted.theme; Please flip both lines.

Vlad, test is fine. Do me a favor and upload a quick edit w/ the lines swapped per Henrik and I'll r+ and land it tomorrow. Reading the code, seems like the order probably doesn't actually matter, but it's good form to tear things down in reverse order from how they're encountered when running setup and test.

Geo, we decided to have our own themes and add-ons to test on, now me and alex are working on example to land on litmus-data repo. Once the theme necessary for this test lands there, it will be my pleasure to fix the nit asap. Thanks!

Comment on attachment 546752 [details] [diff] [review] patch v1.0 Vlad, sounds good. I'll look forward to that. In the meantime I'm r-'ing to clear my queue and so I get a notification on your new version.

Our example theme is finale on mozqa.com so here is the fix. Geo, could you be kind enough to give some feedback on this patch? Thanks

Comment on attachment 559117 [details] [diff] [review] patch v1.1 all branches Let me give you feedback so you can react faster... >+const THEME = { >+ name: "Theme (Plain)", >+ id: "plain.theme@quality.mozilla.org", >+ url: "http://mozqa.com/" + >+ "data/firefox/addons/install.html?addon=themes/plain.jar" >+}; We want to install themes from localhost and not from mozqa.com. With Remus patch those file will be present in the data folder.

Ok then, will wait for that to happen

Comment on attachment 559117 [details] [diff] [review] patch v1.1 all branches Canceling review based on previous comments. Please re-request once they have been addressed.

This needs also the theme install page in mozmill-tests/data/addons folder. Otherwise firefox doesn't know what do to with a .jar file unless you perform drag and drop into the add-ons manager. Which isn't the case in this test

Please prioritize resolving the dependency.

I would have been very happy to fix the dependency, but currently I don;t have access to hg to upload anything on the repo. Therefore, I would kindly ask anyone which has rights to do this one for me, and upload the theme installation page under mozmill-tests/data folder, in the same subfolder as plain.jar example theme exists. Path to the sample theme is: mozmill-tests/data/addons/plain.jar Maybe create another subfolder like: mozmill-tests/data/addons/themes/plain.jar The installation page can be extracted from http://mozqa.com/data/firefox/addons/ With this matter solved, I can easily fix this patch. Thanks

Following up with comment 14, the dependency will be fixed once bug 685515 lands

Fixed. Now we are installing the theme from mozmill-tests/data

(In reply to Maniac Vlad Florin (:vladmaniac) from comment #15) > Following up with comment 14, the dependency will be fixed once bug 685515 > lands Does the following check-in fulfill the dependency for this bug? http://hg.mozilla.org/qa/mozmill-tests/rev/2cabda6f7f68

(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #17) > (In reply to Maniac Vlad Florin (:vladmaniac) from comment #15) > > Following up with comment 14, the dependency will be fixed once bug 685515 > > lands > > Does the following check-in fulfill the dependency for this bug? > http://hg.mozilla.org/qa/mozmill-tests/rev/2cabda6f7f68 Yes Anthony, it does fulfill the dependency for all theme installation related mozmill test bugs.

Comment on attachment 562756 [details] [diff] [review] patch v1.2 all branches [checked-in] Landed: http://hg.mozilla.org/qa/mozmill-tests/rev/05728cbb228e (default) http://hg.mozilla.org/qa/mozmill-tests/rev/ccfca01a04f1 (mozilla-aurora) http://hg.mozilla.org/qa/mozmill-tests/rev/75d95029a8f3 (mozilla-beta) http://hg.mozilla.org/qa/mozmill-tests/rev/9a0f8ecb1397 (mozilla-release)

Please check the next results and mark verified if passing, reopen if not.

I don't see related failures in Default branch failures: http://mozmill-release.brasstacks.mozilla.com/#/functional/top?branch=10.0&platform=All&from=2011-09-30&to=2011-10-01 Aurora branch failures: http://mozmill-release.brasstacks.mozilla.com/#/functional/top?branch=9.0&platform=All&from=2011-09-30&to=2011-10-01 Beta branch failures: http://mozmill-release.brasstacks.mozilla.com/#/functional/top?branch=8.0&platform=All&from=2011-09-30&to=2011-10-01 Release branch failures: http://mozmill-release.brasstacks.mozilla.com/#/functional/top?branch=7.0&platform=All&from=2011-09-30&to=2011-10-01 Marking as VERIFIED