As our first choice for installing addons is localhost, we have to copy over the addons and install file to the mozmill-tests repository.

Copied over the entire addons directory. Tested with a modified patch from bug 677193 and it works fine.

Comment on attachment 559129 [details] [diff] [review] patch v1.0 Please leave alone the blocklist subfolder. We don't need it right now. Also have you tested that the install.html is working from localhost with a currently in development test?

removed the blocklist folder (In reply to Henrik Skupin (:whimboo) from comment #2) > Comment on attachment 559129 [details] [diff] [review] > patch v1.0 > > Also have you tested that the install.html is working from localhost with a > currently in development test? I did, and I've also stated that in comment 1 . It works fine. The link is not using the file:// protocol, it's using http://localhost/ and it's working ok.

stripped large.xpi as discussed on irc

A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/18035833

Comment on attachment 559139 [details] [diff] [review] patch v3.0 Lets wait. I thought I have removed the restartless.xpi extension, which is not really restartless. Also the multipackaged XPI we should update first, so it doesn't contain real extensions which could break Firefox with a new major release. Sorry, haven't seen that those extensions were also part of the patch. Please make sure that only empty.xpi, icons.xpi, and long-name.xpi are part of the patch. You can also remove .htaccess which is not necessary. Alex, can you please file a bug in infrastructure so we can remove the restartless.xpi and update the multipackaged XPI? Thanks.

(In reply to Henrik Skupin (:whimboo) from comment #6) > Comment on attachment 559139 [details] [diff] [review] > patch v3.0 > > Lets wait. I thought I have removed the restartless.xpi extension, which is > not really restartless. Also the multipackaged XPI we should update first, > so it doesn't contain real extensions which could break Firefox with a new > major release. Sorry, haven't seen that those extensions were also part of > the patch. Please make sure that only empty.xpi, icons.xpi, and > long-name.xpi are part of the patch. You can also remove .htaccess which is > not necessary. I can bundle two already existing extensions in a multipackage tomorrow, icons.xpi and plain.jar . Would that be enough? > > Alex, can you please file a bug in infrastructure so we can remove the > restartless.xpi and update the multipackaged XPI? Thanks. What's wrong with the restartless.xpi? It just landed in Bug 684867. Why should that be removed? I'll file a bug for the multipackage

(In reply to Alex Lakatos from comment #7) > I can bundle two already existing extensions in a multipackage tomorrow, > icons.xpi and plain.jar . Would that be enough? I would use the empty.xpi just to make the package as small as possible. Please file a new bug and make it dependent. > What's wrong with the restartless.xpi? It just landed in Bug 684867. Why > should that be removed? Oh, I don't watch the infrastructure component. So I haven't seen its landing. There is still a small change to be made. I have reopened the bug.

This patch copies icons.xpi from litmus-data. It is a dependency for testEnableDisableExtension which has already been checked in and is failing.

Comment on attachment 560659 [details] [diff] [review] Patch: icons.xpi >diff --git a/data/addons/icons.xpi b/data/addons/icons.xpi The have a correct location regarding on Litmus the extension has to be placed under data/addons/extensions.

That's because the test which was checked-in had the test in data/addons/icons.xpi. I will have to create a new patch for this location.

Comment on attachment 560665 [details] [diff] [review] Patch: icons.xpi v2.0 [checked-in] Landed: http://hg.mozilla.org/qa/mozmill-tests/rev/f205eac2e68d (default) http://hg.mozilla.org/qa/mozmill-tests/rev/3b9997afc6de (mozilla-aurora) http://hg.mozilla.org/qa/mozmill-tests/rev/150e0365b504 (mozilla-beta) http://hg.mozilla.org/qa/mozmill-tests/rev/d772d29643c7 (mozilla-release)

Alex, please take care of the rest of the addons on this bug and make sure any tests which depend on them have dependencies applied.

Alex, ping? We have to resolve this dependency soon. Can you please work on the patch for the final extensions?

Henrik, pong. The only dependency on this bug( Bug 685814 ) has a patch awaiting your review. If it passes, I can do a patch for this one asap.

Copied the folder, without icons.xpi, large.xpi and blocklist/

Comment on attachment 562000 [details] [diff] [review] patch v4.0 I had to reopen the bug for the restartless extension. But feel free to update the patch so it doesn't contain the restartless one, for the immediate check-in. Also ask Anthony for review. f+ with this addressed. We can checkin the restartless extension later on.

Removed restartless.xpi as per comment 17. Removed the extensions mentioned in comment 16 as well

Comment on attachment 562409 [details] [diff] [review] patch v5.0 (without restartless.xpi) Henrik, can you review this patch? I won't have time given the Firefox 7 release activity.

Anthony, so please get at least this patch landed across our main branches then. That way SV can continue in creating tests for the add-ons manager tomorrow. thanks.

I will not have time due to Firefox 7, 3.6.23 activities. Henrik, Geo, or Dave, can one of you land this?

Landed as: http://hg.mozilla.org/qa/mozmill-tests/rev/2cabda6f7f68 (default) http://hg.mozilla.org/qa/mozmill-tests/rev/95b4e18453b8 (mozilla-aurora) http://hg.mozilla.org/qa/mozmill-tests/rev/d88b9c341038 (mozilla-beta) http://hg.mozilla.org/qa/mozmill-tests/rev/0a6092e282d5 (mozilla-release)

Reopening as the patch for restartless.xpi still needs to be done

Updated install.html to use .textContent instead of .text as of Henrik's correction in litmus-data repo.

Patch looks fine. Does this need to land across all branches on mozmill-tests?

(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #25) > Patch looks fine. Does this need to land across all branches on > mozmill-tests? Only for the rapid release branches. It's already on 1.9.2.

Copying over restartless.xpi, the last addon that needed copying.

Landed as: http://hg.mozilla.org/qa/mozmill-tests/rev/cf38aaac14d4 (default) http://hg.mozilla.org/qa/mozmill-tests/rev/a7c54fb0af0d (aurora) http://hg.mozilla.org/qa/mozmill-tests/rev/fab2105aa73e (beta) http://hg.mozilla.org/qa/mozmill-tests/rev/7c4303225415 (release)

Removing checkin-needed based on comment 28.

Please read: bug 684867 comment 26

Bug 684867 has been closed due to misinformation. Sorry for that.