User Agent: Mozilla/5.0 (X11; Linux i686; rv:6.0) Gecko/20110328 Firefox/6.0 Build ID: 20110823115500 Steps to reproduce: The extensions/gio/nsGIOProtocolHandler.cpp does not build because it uses an obsolete interface (mozilla/Monitor.h). Attached patch fix it.

Comment on attachment 558187 [details] [diff] [review] gio-protocol-handler patch (v1) Review of attachment 558187 [details] [diff] [review]: ----------------------------------------------------------------- Monitor.h is not obsolete as far as I know. You need to use MonitorAutoLock instead of MonitorAutoEnter. Does this monitor actually have to be reentrant? If not, let's not make it so.

Monitor was renamed to ReentrantMonitor: http://hg.mozilla.org/mozilla-central/rev/0912e0484031 But nsGIOProtocolHandler was not part of this commit.

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #1) > You need to use MonitorAutoLock instead of MonitorAutoEnter. I will fix it. Thanks. > Does this monitor actually have to be reentrant? If not, let's not make it > so. I have made the same renaming in the nsGIOProtocolHandler as well as in rev/0912e0484031. What should I use in nsGIOProtocolHandler instead of Monitor ?

Marking this one as dupe to the newer one just because it's unconfirmed and both have "almost done" patches.