Closed
Bug 696030
Opened 13 years ago
Closed 13 years ago
nsGIOProtocolHandler.cpp:241:3: error: ‘MonitorAutoEnter’ is not a member of ‘mozilla’ when building with --enable-extensions=gio
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: chrisccoulson, Assigned: chrisccoulson)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
When building with --enable-extensions=gio, I get this build failure: c++ -o nsGIOProtocolHandler.o -c -I../../dist/stl_wrappers -I../../dist/system_wrappers -include /home/chr1s/src/firefox/mozilla-central/config/gcc_hidden.h -DOSTYPE=\"Linux3.0\" -DOSARCH=Linux -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/home/chr1s/src/firefox/mozilla-central/extensions/gio -I. -I../../dist/include -I../../dist/include/nsprpub -I/home/chr1s/src/firefox/mozilla-central/obj-x86_64-unknown-linux-gnu/dist/include/nspr -I/home/chr1s/src/firefox/mozilla-central/obj-x86_64-unknown-linux-gnu/dist/include/nss -fPIC -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -pedantic -Wno-long-long -g -fno-strict-aliasing -std=gnu++0x -pthread -ffunction-sections -fdata-sections -pipe -DDEBUG -D_DEBUG -DTRACING -g -Os -freorder-blocks -fno-omit-frame-pointer -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MF .deps/nsGIOProtocolHandler.pp /home/chr1s/src/firefox/mozilla-central/extensions/gio/nsGIOProtocolHandler.cpp /home/chr1s/src/firefox/mozilla-central/extensions/gio/nsGIOProtocolHandler.cpp: In member function ‘void nsGIOInputStream::SetMountResult(MountOperationResult, gint)’: /home/chr1s/src/firefox/mozilla-central/extensions/gio/nsGIOProtocolHandler.cpp:241:3: error: ‘MonitorAutoEnter’ is not a member of ‘mozilla’ /home/chr1s/src/firefox/mozilla-central/extensions/gio/nsGIOProtocolHandler.cpp:241:29: error: expected ‘;’ before ‘mon’ /home/chr1s/src/firefox/mozilla-central/extensions/gio/nsGIOProtocolHandler.cpp:244:3: error: ‘mon’ was not declared in this scope /home/chr1s/src/firefox/mozilla-central/extensions/gio/nsGIOProtocolHandler.cpp: In member function ‘nsresult nsGIOInputStream::MountVolume()’: /home/chr1s/src/firefox/mozilla-central/extensions/gio/nsGIOProtocolHandler.cpp:266:3: error: ‘MonitorAutoEnter’ is not a member of ‘mozilla’ /home/chr1s/src/firefox/mozilla-central/extensions/gio/nsGIOProtocolHandler.cpp:266:29: error: expected ‘;’ before ‘mon’ /home/chr1s/src/firefox/mozilla-central/extensions/gio/nsGIOProtocolHandler.cpp:269:5: error: ‘mon’ was not declared in this scope make[6]: *** [nsGIOProtocolHandler.o] Error 1
Assignee | ||
Comment 1•13 years ago
|
||
Assignee: nobody → chrisccoulson
Attachment #568355 -
Flags: review?(karlt)
Comment 2•13 years ago
|
||
This doesn't need to be a re-entrant monitor, so a better fix would be to change MonitorAutoEnter to MonitorAutoLock.
Updated•13 years ago
|
Assignee | ||
Updated•13 years ago
|
Attachment #568355 -
Attachment is obsolete: true
Attachment #568355 -
Flags: review?(karlt)
Comment 5•13 years ago
|
||
Comment on attachment 584745 [details] [diff] [review] Use MonitorAutoEnter rather than MonitorAutoLock in nsGIOProtocolHandler The checkin comment just needs touching up. The method names are round the wrong way or something.
Attachment #584745 -
Flags: review?(karlt) → review+
Comment 7•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/21c2b8c54c54
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•