When building with --enable-extensions=gio, I get this build failure: c++ -o nsGIOProtocolHandler.o -c -I../../dist/stl_wrappers -I../../dist/system_wrappers -include /home/chr1s/src/firefox/mozilla-central/config/gcc_hidden.h -DOSTYPE=\"Linux3.0\" -DOSARCH=Linux -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/home/chr1s/src/firefox/mozilla-central/extensions/gio -I. -I../../dist/include -I../../dist/include/nsprpub -I/home/chr1s/src/firefox/mozilla-central/obj-x86_64-unknown-linux-gnu/dist/include/nspr -I/home/chr1s/src/firefox/mozilla-central/obj-x86_64-unknown-linux-gnu/dist/include/nss -fPIC -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -pedantic -Wno-long-long -g -fno-strict-aliasing -std=gnu++0x -pthread -ffunction-sections -fdata-sections -pipe -DDEBUG -D_DEBUG -DTRACING -g -Os -freorder-blocks -fno-omit-frame-pointer -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MF .deps/nsGIOProtocolHandler.pp /home/chr1s/src/firefox/mozilla-central/extensions/gio/nsGIOProtocolHandler.cpp /home/chr1s/src/firefox/mozilla-central/extensions/gio/nsGIOProtocolHandler.cpp: In member function ‘void nsGIOInputStream::SetMountResult(MountOperationResult, gint)’: /home/chr1s/src/firefox/mozilla-central/extensions/gio/nsGIOProtocolHandler.cpp:241:3: error: ‘MonitorAutoEnter’ is not a member of ‘mozilla’ /home/chr1s/src/firefox/mozilla-central/extensions/gio/nsGIOProtocolHandler.cpp:241:29: error: expected ‘;’ before ‘mon’ /home/chr1s/src/firefox/mozilla-central/extensions/gio/nsGIOProtocolHandler.cpp:244:3: error: ‘mon’ was not declared in this scope /home/chr1s/src/firefox/mozilla-central/extensions/gio/nsGIOProtocolHandler.cpp: In member function ‘nsresult nsGIOInputStream::MountVolume()’: /home/chr1s/src/firefox/mozilla-central/extensions/gio/nsGIOProtocolHandler.cpp:266:3: error: ‘MonitorAutoEnter’ is not a member of ‘mozilla’ /home/chr1s/src/firefox/mozilla-central/extensions/gio/nsGIOProtocolHandler.cpp:266:29: error: expected ‘;’ before ‘mon’ /home/chr1s/src/firefox/mozilla-central/extensions/gio/nsGIOProtocolHandler.cpp:269:5: error: ‘mon’ was not declared in this scope make[6]: *** [nsGIOProtocolHandler.o] Error 1

This doesn't need to be a re-entrant monitor, so a better fix would be to change MonitorAutoEnter to MonitorAutoLock.

Comment on attachment 584745 [details] [diff] [review] Use MonitorAutoEnter rather than MonitorAutoLock in nsGIOProtocolHandler The checkin comment just needs touching up. The method names are round the wrong way or something.