David Anderson [:dvander] - inactive, e-mail if emergency Reporter
	Description • 13 years ago

mozilla-inbound has spidermonkey-only builds, we would like these on the IonMonkey TBPL as well. Ideally for all platforms that the infrastructure can support.

We only need the vanilla ones that build either debug or optimize.

	bhearsum@mozilla.com (:bhearsum) Assignee
	Comment 3 • 13 years ago

These two patches almost get things going. Apparently the Spidermonkey scripts don't actually pay attention to the repository set in the configs, though., so with just these we'll have SpiderMonkey tests on the Ionmonkey tree, but pulling mozilla-integration. I'll try to dig into that if I get time this week.

	bhearsum@mozilla.com (:bhearsum) Assignee
	Comment 4 • 13 years ago

Rather, pulling mozilla-inbound

	David Anderson [:dvander] - inactive, e-mail if emergency Reporter
	Comment 5 • 13 years ago

Thanks for working on this! What is the ETA? We are in pretty dire need of the test coverage.

	bhearsum@mozilla.com (:bhearsum) Assignee
	Comment 6 • 13 years ago

(In reply to David Anderson [:dvander] from comment #5)
> Thanks for working on this! What is the ETA? We are in pretty dire need of
> the test coverage.

I'll try to get this ready to land by the end of the week. Sometime next week at the very latest.

	bhearsum@mozilla.com (:bhearsum) Assignee
	Comment 7 • 13 years ago

I think I've got something ready to go now, but the build is failing with:
/usr/bin/ccache /tools/gcc-4.5/bin/g++ -o Assembler-x86-shared.o -c  -I/builds/slave/ionmonkey-lnx-spidermonkey-warnaserr/objdir/dist/system_wrappers_js -include ../../src/js/src/config/gcc_hidden.h -DOSTYPE=\"Linux2.6.18-8\" -DOSARCH=Linux -DEXPORT_JS_API -DIMPL_MFBT  -I../../src/js/src -I. -I/builds/slave/ionmonkey-lnx-spidermonkey-warnaserr/objdir/dist/include -I/builds/slave/ionmonkey-lnx-spidermonkey-warnaserr/objdir/dist/include/nsprpub  -I/builds/slave/ionmonkey-lnx-spidermonkey-warnaserr/objdir/dist/include/nspr  -I../../src/js/src -I../../src/js/src/assembler -I../../src/js/src/yarr  -fPIC  -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -pedantic -Wno-long-long -fno-tree-vrp -pthread -pipe  -DNDEBUG -DTRIMMED -g -O3 -freorder-blocks -finline-limit=50 -fomit-frame-pointer -Werror -DUSE_SYSTEM_MALLOC=1 -DENABLE_ASSEMBLER=1 -DENABLE_JIT=1   -DMOZILLA_CLIENT -include ./js-confdefs.h -MD -MF .deps/Assembler-x86-shared.pp /builds/slave/ionmonkey-lnx-spidermonkey-warnaserr/src/js/src/ion/shared/Assembler-x86-shared.cpp
Lowering-x86.cpp
/usr/bin/ccache /tools/gcc-4.5/bin/g++ -o Lowering-x86.o -c  -I/builds/slave/ionmonkey-lnx-spidermonkey-warnaserr/objdir/dist/system_wrappers_js -include ../../src/js/src/config/gcc_hidden.h -DOSTYPE=\"Linux2.6.18-8\" -DOSARCH=Linux -DEXPORT_JS_API -DIMPL_MFBT  -I../../src/js/src -I. -I/builds/slave/ionmonkey-lnx-spidermonkey-warnaserr/objdir/dist/include -I/builds/slave/ionmonkey-lnx-spidermonkey-warnaserr/objdir/dist/include/nsprpub  -I/builds/slave/ionmonkey-lnx-spidermonkey-warnaserr/objdir/dist/include/nspr  -I../../src/js/src -I../../src/js/src/assembler -I../../src/js/src/yarr  -fPIC  -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -pedantic -Wno-long-long -fno-tree-vrp -pthread -pipe  -DNDEBUG -DTRIMMED -g -O3 -freorder-blocks -finline-limit=50 -fomit-frame-pointer -Werror -DUSE_SYSTEM_MALLOC=1 -DENABLE_ASSEMBLER=1 -DENABLE_JIT=1   -DMOZILLA_CLIENT -include ./js-confdefs.h -MD -MF .deps/Lowering-x86.pp /builds/slave/ionmonkey-lnx-spidermonkey-warnaserr/src/js/src/ion/x86/Lowering-x86.cpp
CodeGenerator-x86.cpp
/usr/bin/ccache /tools/gcc-4.5/bin/g++ -o CodeGenerator-x86.o -c  -I/builds/slave/ionmonkey-lnx-spidermonkey-warnaserr/objdir/dist/system_wrappers_js -include ../../src/js/src/config/gcc_hidden.h -DOSTYPE=\"Linux2.6.18-8\" -DOSARCH=Linux -DEXPORT_JS_API -DIMPL_MFBT  -I../../src/js/src -I. -I/builds/slave/ionmonkey-lnx-spidermonkey-warnaserr/objdir/dist/include -I/builds/slave/ionmonkey-lnx-spidermonkey-warnaserr/objdir/dist/include/nsprpub  -I/builds/slave/ionmonkey-lnx-spidermonkey-warnaserr/objdir/dist/include/nspr  -I../../src/js/src -I../../src/js/src/assembler -I../../src/js/src/yarr  -fPIC  -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -pedantic -Wno-long-long -fno-tree-vrp -pthread -pipe  -DNDEBUG -DTRIMMED -g -O3 -freorder-blocks -finline-limit=50 -fomit-frame-pointer -Werror -DUSE_SYSTEM_MALLOC=1 -DENABLE_ASSEMBLER=1 -DENABLE_JIT=1   -DMOZILLA_CLIENT -include ./js-confdefs.h -MD -MF .deps/CodeGenerator-x86.pp /builds/slave/ionmonkey-lnx-spidermonkey-warnaserr/src/js/src/ion/x86/CodeGenerator-x86.cpp
cc1plus: warnings being treated as errors
/builds/slave/ionmonkey-lnx-spidermonkey-warnaserr/src/js/src/ion/x86/CodeGenerator-x86.cpp: In member function 'virtual bool js::ion::CodeGeneratorX86::visitBox(js::ion::LBox*)':
/builds/slave/ionmonkey-lnx-spidermonkey-warnaserr/src/js/src/ion/x86/CodeGenerator-x86.cpp:131:24: error: unused variable 'a'
make[1]: *** [CodeGenerator-x86.o] Error 1
make[1]: Leaving directory `/builds/slave/ionmonkey-lnx-spidermonkey-warnaserr/objdir/js'

Looks like a code issue to me (which is exactly why we need this running!) - can you confirm, David?

	bhearsum@mozilla.com (:bhearsum) Assignee
	Comment 9 • 13 years ago

Chris, I spent a bit of time trying to make it really trivial to add new branches to SpiderMonkey and other projects, but I couldn't figure out a good way. (My best idea was to emulate what we do for Firefox branches: GLOBAL vars somewhere, list of branches, and a loop to set things -- it seemed like overkill.

	bhearsum@mozilla.com (:bhearsum) Assignee
	Comment 10 • 13 years ago

Per IRC with dvander, the issue noted in comment #7 is a developer one. With that being the case, I'm going to land these changes. They'll hit production in the next reconfig, probably tomorrow or friday.

	bhearsum@mozilla.com (:bhearsum) Assignee
	Comment 11 • 13 years ago

Comment on attachment 564848 [details] [diff] [review]
set HG_REPO for spidermonkey builds; make it easier to support multiple instances of multiple projects

Had to commit this as a follow-up, because I failed to rediff before posting the patch:
diff --git a/misc.py b/misc.py
index c89e265..591abf7 100644
--- a/misc.py
+++ b/misc.py
@@ -3000,7 +3000,7 @@ def generateSpiderMonkeyObjects(config, SLAVES):
             slaves = SLAVES[base_platform]
             interpreter = None
 
-        env = config['env'][platform]
+        env = config['env'][platform].copy()
         env['HG_REPO'] = config['hgurl'] + config['repo_path']
 
         for variant in variants:

	bhearsum@mozilla.com (:bhearsum) Assignee
	Comment 12 • 13 years ago

Reconfig happened last night, these jobs are showing up on Ionmonkey now, failing with the error mentioned in comment #7.

	David Anderson [:dvander] - inactive, e-mail if emergency Reporter
	Comment 13 • 13 years ago

It looks like these builds are not happening for debug?

	bhearsum@mozilla.com (:bhearsum) Assignee
	Comment 14 • 13 years ago

(In reply to David Anderson [:dvander] from comment #0)
> mozilla-inbound has spidermonkey-only builds, we would like these on the
> IonMonkey TBPL as well. Ideally for all platforms that the infrastructure
> can support.
> 
> We only need the vanilla ones that build either debug or optimize.

(In reply to David Anderson [:dvander] from comment #13)
> It looks like these builds are not happening for debug?

Based on your original comment, I thought you only wanted the one or the other. I can add the debug ones, though. Maybe we should just be running all of the ones that currently run on mozilla-inbound?

	David Anderson [:dvander] - inactive, e-mail if emergency Reporter
	Comment 15 • 13 years ago

Yeah, that would be great, thanks :)

	bhearsum@mozilla.com (:bhearsum) Assignee
	Comment 17 • 13 years ago

Comment on attachment 565282 [details] [diff] [review]
enable all debug spidermonkey builds on ionmonkey

Landed. There's a reconfig happening soon, too, so these jobs should start showing up in the next hour or two.

	bhearsum@mozilla.com (:bhearsum) Assignee
	Comment 18 • 13 years ago

Reconfig is done. You should see the full set of Spidermonkey builders next time you land in IonMonkey.