Open
Bug 686956
Opened 13 years ago
Updated 2 years ago
Download complete notification sent through notification-daemon should have "transient" hint set
Categories
(Toolkit :: Downloads API, defect)
Tracking
()
NEW
People
(Reporter: wodny, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux i686; rv:6.0.2) Gecko/20100101 Firefox/6.0.2 Iceweasel/6.0.2 Build ID: 20110906093027 Steps to reproduce: Download a file. Actual results: "Download complete" notification appeared and then persisted in notification-daemon (0.7.1-5). Clearing all the notifications is boring. Expected results: "Download complete" notification should appear and then not persist (just disappear). Hint "transient" should be set to True.
Updated•13 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Product: Firefox → Toolkit
QA Contact: general → general
Comment 1•13 years ago
|
||
Works es expected on Fedora 15 (notification-daemon-0.7.1-1.fc15.i686). I had some problems with the notifications too but it showed up to be an issue with download manager setting. Which value do you have in browser.download.manager.showAlertInterval?
Comment 2•13 years ago
|
||
Ahh, I see it now. There's a different behaviour in gnome-shell and fall-back mode.
Comment 3•13 years ago
|
||
Simple fix. I guess this fix changes the notification for all apps/events (thunderbird new message for instance). Do we want to make this change for firefox only or not?
Attachment #569925 -
Flags: feedback?(karlt)
Comment 4•13 years ago
|
||
(In reply to Martin Stránský from comment #3) > Simple fix. I guess this fix changes the notification for all apps/events > (thunderbird new message for instance). Yes, I expect we actually want different behaviour for different notifications. I suspect ideally we'd set the category to "transfer.complete" for a "download complete notification". http://people.gnome.org/%7Emccann/docs/notification-spec/notification-spec-latest.html I'm not actually sure whether or not the "transient" hint should be explicitly set. The spec doesn't seem to specify the default value, so perhaps it's better to let the notification program decide (perhaps through user configuration). The category sounds similar to the description of the "name" parameter to showAlertNotification: "On OS X with Growl, users can disable notifications with a given name", but the download manager does not currently provide a name to recognize.
Component: General → Download Manager
QA Contact: general → download.manager
Updated•13 years ago
|
Attachment #569925 -
Flags: feedback?(karlt)
Reporter | ||
Comment 5•13 years ago
|
||
Sounds good. I didn't notice the possibility of using "transfer.complete". I don't think the notification-daemon currently supports this type of configuration, but it seems to be the right way. I'm going to file a wishlist bug to notification-daemon when this one is resolved that way.
Comment 6•13 years ago
|
||
(In reply to Karl Tomlinson (:karlt) from comment #4) > Yes, I expect we actually want different behaviour for different > notifications. > > I suspect ideally we'd set the category to "transfer.complete" for a > "download complete notification". > http://people.gnome.org/%7Emccann/docs/notification-spec/notification-spec- > latest.html > > I'm not actually sure whether or not the "transient" hint should be > explicitly set. > The spec doesn't seem to specify the default value, so perhaps it's better > to let the notification program decide (perhaps through user configuration). See bug 404738. Firefox uses libnotify recently which hides the dbus implementation details. Do you suggest the way of bug 404738 (switch linux notifications to DBUS directly) or bend the libnotify somehow?
Comment 7•13 years ago
|
||
BTW. the "transient" hint seems to be widely used by gtk3 apps: http://live.gnome.org/GnomeShell/Design/Guidelines/MessageTray/Compatibility
Comment 8•13 years ago
|
||
Anyway, to specify "transfer.complete" by notify_notification_set_category() make no difference, notifications are still stored.
Comment 9•13 years ago
|
||
I'm not sure that having the notifications stored is a problem if the activate button works, because that can be useful. Having multiple "All files have finished downloading" messages saved may be a bit silly though. That depends on whether the activate button is download-specific or just tries to open the download manager to show them all.
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•