Karl Tomlinson (:karlt) Reporter
	Description • 13 years ago

Steps to reproduce:

Download a file.


Actual results:

"Download complete" notification appears with an "Activate" button.
Clicking the activate button does nothing.
ed and then persisted in notification-daemon (0.7.1-5). Clearing all the notifications is boring.


Expected results:

Probably no "Activate" button.
Perhaps the "Activate" button might open the download manager, but the strings "Activate" and "All files have finished downloading" are not clear if that is the intended action.


Possibly related to bug 686956.
This is observed under KDE.  I haven't tested other notification systems.

	Karl Tomlinson (:karlt) Reporter
	Comment 1 • 13 years ago

(In reply to Karl Tomlinson (:karlt) from comment #0)
> ed and then persisted in notification-daemon (0.7.1-5). Clearing all the
> notifications is boring.

Oops, please ignore this copy/paste remnant.

	Karl Tomlinson (:karlt) Reporter
	Comment 2 • 13 years ago

It seems the activate button does actually focus the download manager if no focus changes have happened since the download was initiated.

This may be an issue with passing the wrong timestamp in the focus request.

	Martin Stránský [:stransky] (ni? me)
	Comment 3 • 13 years ago

So shall the "Activate" be changed to "Open"? It may be more appropriate when it opens the download manager.

	Martin Stránský [:stransky] (ni? me)
	Comment 4 • 13 years ago

Anyway, the "Activate" button is useful when browser.download.manager.showWhenStarting is false and download manager is hidden by default.

	Karl Tomlinson (:karlt) Reporter
	Comment 5 • 13 years ago

"View" might be better than "Activate" in this particular case, but the nsIAlertsService API does not provide a way to specify the action label.

"Activate" here is not even localizable.  I wonder whether an empty string would be treated consistently.

(In reply to Karl Tomlinson (:karlt) from comment #2)
> It seems the activate button does actually focus the download manager if no
> focus changes have happened since the download was initiated.

If focus changes have happened, then the download window is sometimes marked as demanding attention (but other times I see nothing).

It may not be possible to fix this without a change to the notification spec, because currently callbacks are not given the timestamp of the click to pass to the focus request.  That may all be a bit awkward through dbus.

	Martin Stránský [:stransky] (ni? me)
	Comment 6 • 13 years ago

(In reply to Karl Tomlinson (:karlt) from comment #5)
> If focus changes have happened, then the download window is sometimes marked
> as demanding attention (but other times I see nothing).

I've tested with browser.download.manager.showWhenStarting set to false and the download window is not even opened unless you hit the "Activate" button.

	Karl Tomlinson (:karlt) Reporter
	Comment 7 • 13 years ago

Yes, there's more than one issue here, but it is now clear that the activate button is meant to have an action, and it works in some situations.