Comment on attachment 570383 [details] [diff] [review] release_sanity compares l10n_changesets locales to shipped locales (for firefox) Review of attachment 570383 [details] [diff] [review]: ----------------------------------------------------------------- ::: buildbot-helpers/release_sanity.py @@ +262,5 @@ > + """Ensure that our l10n-changesets on the master match the repo's shipped locales list""" > + success = True > + shipped_locales = [] > + try: > + shipped_locales_page = urllib2.urlopen(shipped_locales_url) We've got library methods for dealing with shipped-locales. Have a look at getShippedLocales (http://hg.mozilla.org/build/tools/file/2b3920fd4a6e/lib/python/release/l10n.py#l16) and either getPlatformLocales or getAllLocales (http://hg.mozilla.org/build/tools/file/2b3920fd4a6e/lib/python/release/platforms.py#l51) @@ +394,5 @@ > test_success = False > log.error("Error verifying l10n dashboard changesets") > > + #verify that l10n changesets match the shipped locales in firefox product > + if releaseConfig['productName'] == 'firefox': I think this block should be dependent on whether or not both shippedLocalesPath and l10nRevisionFile exists in releaseConfig. The product being Firefox doesn't guarantee that both of those exist, and basing it on attributes rather than products means that this would work for Thunderbird or any other products.

- checking for 'shippedLocalesPath' now so any product that uses this can benefit - added a new function to lib/python/release/platforms.py that returns the list of shipped locales and am now using the existing getShippedLocales instead of my own url reading

Comment on attachment 570849 [details] [diff] [review] release_sanity compares l10n_changesets locales to shipped locales http://hg.mozilla.org/build/tools/rev/92346382b571

Trying to retrieve from a tag which doesn't exist yet: 2011-11-02 21:08:05,586 : ERROR : Failed to retrieve http://hg.mozilla.org/releases/mozilla-beta/raw-file/FIREFOX_8_0b6_BUILD2/browser/locales/shipped-locales Traceback (most recent call last): File "../tools/buildbot-helpers/release_sanity.py", line 407, in <module> sourceRepoPath File "/builds/buildbot/build1/tools/lib/python/release/l10n.py", line 24, in getShippedLocales sl = urlopen(url).read() File "/usr/lib64/python2.6/urllib2.py", line 126, in urlopen return _opener.open(url, data, timeout) File "/usr/lib64/python2.6/urllib2.py", line 397, in open response = meth(req, response) File "/usr/lib64/python2.6/urllib2.py", line 510, in http_response 'http', request, response, code, msg, hdrs) File "/usr/lib64/python2.6/urllib2.py", line 435, in error return self._call_chain(*args) File "/usr/lib64/python2.6/urllib2.py", line 369, in _call_chain result = func(*args) File "/usr/lib64/python2.6/urllib2.py", line 518, in http_error_default raise HTTPError(req.get_full_url(), code, msg, hdrs, fp) urllib2.HTTPError: HTTP Error 404: Not Found We should use the rev we're supposed to be tagging instead.

Comment on attachment 570849 [details] [diff] [review] release_sanity compares l10n_changesets locales to shipped locales Backed out - http://hg.mozilla.org/build/tools/rev/29a13d480a65

getShippedLocales now accepts a revision and if revision is present it assembles the shipped_locales path with that instead of cobbling together the release tag. Added revision=None to the end of the args for getShippedLocales so that nothing should break from this change.

Comment on attachment 571669 [details] [diff] [review] v.2 release_sanity compares l10n_changesets locales to shipped locales for the revision about to be tagged http://hg.mozilla.org/build/tools/rev/e6f09c2c631d