Closed Bug 691161 Opened 13 years ago Closed 13 years ago

Mobile nightly multilocale repack busted with hg share "abort: destination already exists"

Categories

(Release Engineering :: General, defect)

defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philor, Assigned: mozilla)

References

Details

Attachments

(1 file)

Since someone retriggered the Android one and it was green the second time, I'm wildly guessing that the bug is something like "a slave can't build Fennec nightlies a *second* time, only once in its lifetime." https://tbpl.mozilla.org/php/getParsedLog.php?id=6644818&tree=Firefox Android mozilla-central nightly on 2011-10-02 03:08:45 PDT for push 90575e23ea93 03:14:37 INFO - Trying to share /builds/hg-shared/l10n-central/cs to /builds/slave/m-cen-lnx-andrd-ntly/l10n-central/cs 03:14:37 INFO - Sharing /builds/hg-shared/l10n-central/cs to /builds/slave/m-cen-lnx-andrd-ntly/l10n-central/cs. 03:14:37 INFO - Running command: ['hg', 'share', '-U', '/builds/hg-shared/l10n-central/cs', '/builds/slave/m-cen-lnx-andrd-ntly/l10n-central/cs'] 03:14:37 ERROR - abort: destination already exists 03:14:37 ERROR - Error updating /builds/slave/m-cen-lnx-andrd-ntly/l10n-central/cs from shared_repo (/builds/hg-shared/l10n-central/cs): 03:14:37 ERROR - Traceback (most recent call last): 03:14:37 ERROR - 03:14:37 ERROR - File "/builds/slave/m-cen-lnx-andrd-ntly/mozharness/mozharness/base/vcs/mercurial.py", line 402, in _ensure_shared_repo_and_revision 03:14:37 ERROR - return self.share(shared_repo, dest, branch=branch, revision=revision) 03:14:37 ERROR - 03:14:37 ERROR - File "/builds/slave/m-cen-lnx-andrd-ntly/mozharness/mozharness/base/vcs/mercurial.py", line 431, in share 03:14:37 ERROR - throw_exception=True) 03:14:37 ERROR - 03:14:37 ERROR - File "/builds/slave/m-cen-lnx-andrd-ntly/mozharness/mozharness/base/script.py", line 313, in run_command 03:14:37 ERROR - raise subprocess.CalledProcessError(p.returncode, command) 03:14:37 ERROR - 03:14:37 ERROR - CalledProcessError: Command '['hg', 'share', '-U', '/builds/hg-shared/l10n-central/cs', '/builds/slave/m-cen-lnx-andrd-ntly/l10n-central/cs']' returned non-zero exit status 255 03:14:37 ERROR - 03:14:37 INFO - rmtree: /builds/slave/m-cen-lnx-andrd-ntly/l10n-central/cs 03:14:38 INFO - Changing directory to /builds/slave/m-cen-lnx-andrd-ntly. ------------------------------- https://tbpl.mozilla.org/php/getParsedLog.php?id=6644855&tree=Firefox Maemo 5 GTK mozilla-central nightly on 2011-10-02 03:08:45 PDT for push 90575e23ea93 03:20:20 INFO - Trying to share /builds/hg-shared/l10n-central/cs to /builds/slave/m-cen-lnx-maemo5-gtk-ntly/l10n-central/cs 03:20:20 INFO - Sharing /builds/hg-shared/l10n-central/cs to /builds/slave/m-cen-lnx-maemo5-gtk-ntly/l10n-central/cs. 03:20:20 INFO - Running command: ['hg', 'share', '-U', '/builds/hg-shared/l10n-central/cs', '/builds/slave/m-cen-lnx-maemo5-gtk-ntly/l10n-central/cs'] 03:20:20 ERROR - abort: destination already exists 03:20:20 ERROR - Error updating /builds/slave/m-cen-lnx-maemo5-gtk-ntly/l10n-central/cs from shared_repo (/builds/hg-shared/l10n-central/cs): 03:20:20 ERROR - Traceback (most recent call last): 03:20:20 ERROR - 03:20:20 ERROR - File "/builds/slave/m-cen-lnx-maemo5-gtk-ntly/mozharness/mozharness/base/vcs/mercurial.py", line 402, in _ensure_shared_repo_and_revision 03:20:20 ERROR - return self.share(shared_repo, dest, branch=branch, revision=revision) 03:20:20 ERROR - 03:20:20 ERROR - File "/builds/slave/m-cen-lnx-maemo5-gtk-ntly/mozharness/mozharness/base/vcs/mercurial.py", line 431, in share 03:20:20 ERROR - throw_exception=True) 03:20:20 ERROR - 03:20:20 ERROR - File "/builds/slave/m-cen-lnx-maemo5-gtk-ntly/mozharness/mozharness/base/script.py", line 313, in run_command 03:20:20 ERROR - raise subprocess.CalledProcessError(p.returncode, command) 03:20:20 ERROR - 03:20:20 ERROR - CalledProcessError: Command '['hg', 'share', '-U', '/builds/hg-shared/l10n-central/cs', '/builds/slave/m-cen-lnx-maemo5-gtk-ntly/l10n-central/cs']' returned non-zero exit status 255 03:20:20 ERROR - 03:20:20 INFO - rmtree: /builds/slave/m-cen-lnx-maemo5-gtk-ntly/l10n-central/cs
Kicked off another Android nightly. Will reland once I fix (may involve tearing out the mozharness hgtool backend).
Assignee: nobody → aki
Blocks: 651974
This is essentially copying logic from http://hg.mozilla.org/build/tools/file/1df63f8a2c0d/lib/python/util/hg.py#l287 . The problem was an 'hg share' to an existing directory won't work. hgtool falls back to 'hg update' if dest exists and is cloned from HG_SHARE_BASE_DIR. Adding that 'hg update' to mozharness to follow that logic. This also fixes the previously-broken hgtool unit tests in mozharness.
Comment on attachment 564347 [details] [diff] [review] hg update if the dest exists + is cloned from HG_SHARE_BASE_DIR Also ran |python mozharness/scripts/multil10n.py --config-file multi_locale/mozilla-central_linux-android.json --merge-locales --only-pull-locale-source| multiple multiple times in the same directory (with HG_SHARE_BASE_DIR=/builds/hg-shared) to verify that it doesn't die on existing dirs.
Attachment #564347 - Flags: review?(rail)
Comment on attachment 564347 [details] [diff] [review] hg update if the dest exists + is cloned from HG_SHARE_BASE_DIR Looks good
Attachment #564347 - Flags: review?(rail) → review+
Comment on attachment 564347 [details] [diff] [review] hg update if the dest exists + is cloned from HG_SHARE_BASE_DIR Re-enabled mozharness 0.4: http://hg.mozilla.org/build/mozharness/rev/ac5657f27d9a Landed this patch: http://hg.mozilla.org/build/mozharness/rev/e61722287ebb Running 2x Android m-c nightlies.
Attachment #564347 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Ran 2x Android m-c nightlies, which happened to both run on mv-moz2-linux-ix-slave07 and both went green.
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: