Closed Bug 692646 Opened 13 years ago Closed 13 years ago

release mozconfigs should have MOZ_PGO to ensure that we turn PGO on for release builds

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jhford, Assigned: jhford)

References

Details

Attachments

(2 files, 1 obsolete file)

turn PGO back on for release builds
(deleted), patch
nthomas
: review+
mozilla
: review+
jhford
: checked-in+
Details | Diff | Splinter Review
correct patch
(deleted), patch
nthomas
: review+
nthomas
: checked-in+
Details | Diff | Splinter Review
bug 658313 turned off PGO for release builds unintentionally. This should not have happened. This bug tracks putting MOZ_PGO=1 back in to release mozconfigs
This turns PGO back on for release builds on: -mozilla-central -mozilla-beta -mozilla-aurora -mozilla-release Other branches were either untouched or we don't release off them (should they even have release mozconfigs).
Attachment #565390 - Flags: review?(nrthomas)
Comment on attachment 565390 [details] [diff] [review] turn PGO back on for release builds Looks like you missed mozilla2/linux/mozilla-release/release/mozconfig Please fix it up for consistencies sake (even though it won't be used). Got a patch for m-c too ?
Attachment #565390 - Flags: review?(nrthomas) → review+
Comment on attachment 565390 [details] [diff] [review] turn PGO back on for release builds Just being paranoid, a third set of eyes is great.
Attachment #565390 - Flags: review?(aki)
Comment on attachment 565390 [details] [diff] [review] turn PGO back on for release builds +1 for the linux mozilla-release.
Attachment #565390 - Flags: review?(aki) → review+
This patch enables PGO on Linux, Linux64 and Windows for release configs and should flow out to other branches.
Attachment #565423 - Flags: review?(nrthomas)
Attachment #565423 - Flags: checked-in?
Attachment #565423 - Attachment is obsolete: true
Attachment #565423 - Flags: review?(nrthomas)
Attachment #565423 - Flags: checked-in?
Attached patch correct patch (deleted) — — Splinter Review
Turns out I had two patches in the same directory and confused the naming.
Attachment #565428 - Flags: review?(nrthomas)
Attachment #565428 - Flags: checked-in?
Attachment #565428 - Attachment is patch: true
Comment on attachment 565428 [details] [diff] [review] correct patch http://hg.mozilla.org/mozilla-central/rev/0900f062f796
Attachment #565428 - Flags: review?(nrthomas)
Attachment #565428 - Flags: review+
Attachment #565428 - Flags: checked-in?
Attachment #565428 - Flags: checked-in+
Blocks: 692708
Blocks: 658313
No longer blocks: 692708
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: