(no longer active) Reporter
	Description • 13 years ago

I've been running the native UI for the past few days, and one of the problems I've been facing is that Google Reader appears much smaller in the native UI than in the XUL UI, making it barely readable.  I am on a Galaxy S Vibrant phone.

	Matt Brubeck (:mbrubeck) Assignee
	Comment 1 • 13 years ago

The native front-end does not yet support the <meta name="viewport"> tag and related features to scale pages intelligently based on the device size and density.

We don't yet have real zooming implemented in birch; viewport sizing will depend on that.  (People are working on it already, but I don't have a bug number.)

	Matt Brubeck (:mbrubeck) Assignee
	Comment 2 • 13 years ago

This work-in-progress patch doesn't do anything useful yet, but it transplants most of the viewport code from XUL Fennec and gets it running in native Fennec.

	Matt Brubeck (:mbrubeck) Assignee
	Comment 3 • 13 years ago

This is fully-functional, but has some bugs.  For example, the real screen/window size is not exposed to Gecko chrome, so "width=device-width" is currently using the wrong dimensions.

Next step is to integrate this with the displayport patch queue.

	Matt Brubeck (:mbrubeck) Assignee
	Comment 4 • 13 years ago

Updated to latest birch tip.  Still working out some bugs.

	Matt Brubeck (:mbrubeck) Assignee
	Comment 6 • 13 years ago

Rebased to birch tip.

	Matt Brubeck (:mbrubeck) Assignee
	Comment 8 • 13 years ago

Getting very close. This applies on top of the birch-pan-zoom patch queue [1], and it correctly sets the viewport size.  However, the gfx code still stores a viewport size based on the screen size, so the page's viewport gets overridden and reset on the next update from Java.

[1]: http://hg.mozilla.org/users/pwalton_mozilla.com/birch-pan-zoom/

	Matt Brubeck (:mbrubeck) Assignee
	Comment 9 • 13 years ago

This works; it sets and maintains the correct viewport.  Needs some testing, and I should talk to Chris about how to integrate the changes into his patches.

	Patrick Walton (:pcwalton)
	Comment 11 • 13 years ago

The patch applies cleanly, but doesn't seem to set the width to 980 by default for me.

	Armen [:armenzg]
	Comment 12 • 13 years ago

Did something land recently related to this work?

Sites now have a normal width!!! and I wanted to thank whoever did it.

	Patrick Walton (:pcwalton)
	Comment 13 • 13 years ago

(In reply to Armen Zambrano G. [:armenzg] - Release Engineer from comment #12)
> Did something land recently related to this work?
> 
> Sites now have a normal width!!! and I wanted to thank whoever did it.

This changed with the viewport patch. However, it's still wrong -- sites should be 980 by default, unless a <meta viewport> tag is present.

	Matt Brubeck (:mbrubeck) Assignee
	Comment 14 • 13 years ago

This patch sets the viewport width and height correctly.

This does not yet set the correct initial scale; I think we might need to add a way to control zooming from JavaScript (or for the Java code to ask the JS code for an initial zoom level).

	Matt Brubeck (:mbrubeck) Assignee
	Comment 15 • 13 years ago

Bug 704950 might make the zooming part easier to fix.

	Mark Finkle (:mfinkle) (use needinfo?)
	Comment 16 • 13 years ago

Comment on attachment 577359 [details] [diff] [review]
patch


>diff --git a/mobile/android/chrome/content/browser.js b/mobile/android/chrome/content/browser.js

>   startup: function startup() {

>+    ViewportHandler.init();

I didn't notice an uninit() call

>+  get defaultBrowserWidth() {
>+    var width = Services.prefs.getIntPref("browser.viewport.desktopWidth");

let

>+var ViewportHandler = {

>+  handleEvent: function handleEvent(aEvent) {

>+    let tab = BrowserApp.getTabForBrowser(browser);

Maybe I am paranoid, but we should probably check "tab" for null and bail

	Matt Brubeck (:mbrubeck) Assignee
	Comment 17 • 13 years ago

r=mfinkle (via IRC because Bugzilla was down)

	Matt Brubeck (:mbrubeck) Assignee
	Comment 18 • 13 years ago

https://hg.mozilla.org/projects/birch/rev/2ecdcf3961a8
https://hg.mozilla.org/projects/birch/rev/18678a2f8091

	Aaron Train [:aaronmt]
	Comment 20 • 13 years ago

Samsung Nexus S (Android 4.0.1)
20111130040240
http://hg.mozilla.org/projects/birch/rev/4e745f151abd